fix: address code audit findings#27
Merged
Merged
Conversation
- Remove unused image dependency from Cargo.toml - Cache ANSI regex with LazyLock to avoid recompilation per call - Fix N+1 git calls in Split layout (2 calls -> 1) - Remove dead FIXME code in patch staging logic - Add status_message field for error display in TUI - Show commit errors in UI instead of stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses findings from a comprehensive code audit:
imagedependency from Cargo.toml (~500KB savings)LazyLockto avoid recompilation per search linestatus_messagefield for error display in TUITest plan
cargo buildpasses with no warningscargo clippypasses with no warningscargo test- all 27 tests pass