search messenger directory one level more#39
Open
coopwilliams wants to merge 1 commit intoMasterScrat:masterfrom
Open
search messenger directory one level more#39coopwilliams wants to merge 1 commit intoMasterScrat:masterfrom
coopwilliams wants to merge 1 commit intoMasterScrat:masterfrom
Conversation
Collaborator
|
I would prefer to use glob.glob(os.path.join(file_path, '**', '*.json') recursive=True)This is supported after Python 3.5+. |
Owner
|
I'm not sure we should import I'd prefer to import directly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the problem that messenger.py could not locate .JSON files in Facebook files exported as recently as 11/05/2019. If one copies the contents of the exported 'messages' folder into 'rawdata/messenger', the files therein are one level too deep to be found. I think Facebook's export style must have changed.
This commit adds one more layer to the search for files, and the messenger parser now finds the .json files that it was missing before.
Example directory structure for reference:
'Chatistics/raw_data/messenger/inbox/usernamehere/message_1.json'