Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @Zeviraty and @minhtrancccp for pointing out faults in the provider logic.
@minhtrancccp You also suggested having a token file for managing the credentials, you can do that in the config file. (delete current
~/.config/gitfetch/gitfetch.confto reset the file)I will let this PR linger for 1-2 days if anyone wants to test it, I have not been able to recreate any bugs.
In the meantime I am working on better
GITFETCH_DEBUG=1flag and adding it to the--helpSummary
Revamped Provider logic to into a data class that was suggested from this PR #69
This should fix:
Changes
[github],[gitlab], etc.)