Skip to content

5 add datasets#10

Merged
JeremieGince merged 3 commits intodevfrom
5-add-datasets
Nov 2, 2025
Merged

5 add datasets#10
JeremieGince merged 3 commits intodevfrom
5-add-datasets

Conversation

@JeremieGince
Copy link
Contributor

@JeremieGince JeremieGince commented Nov 2, 2025

Description

This pull request adds support for the RetinaMNIST dataset to the project. It introduces a new dataset class, integrates it into the dataset registry, and provides comprehensive unit tests to ensure correct functionality.

RetinaMNIST dataset integration:

  • Added a new RetinaMNISTDataset class in retinamnist_dataset.py, supporting loading, preprocessing, and combining train/validation splits for the RetinaMNIST dataset, with appropriate transformations and output shape handling.
  • Registered RetinaMNISTDataset in the dataset_name_to_type_map in __init__.py to make it available for use throughout the codebase.

Testing:

  • Added a new test suite test_retinamnist_dataset.py with fixtures and tests for initialization, data retrieval, tensor conversion, length, and output shape of RetinaMNISTDataset. Uses mocking to avoid external dependencies.

Checklist

Please complete the following checklist when submitting a PR. The PR will not be reviewed until all items are checked.

  • All new features include a unit test.
    Make sure that the tests passed and the coverage is
    sufficient by running pytest tests --cov=src --cov-report=term-missing.
  • All new functions and code are clearly documented.
  • The code is formatted using Black.
    You can do this by running black src tests.
  • The imports are sorted using isort.
    You can do this by running isort src tests.
  • The code is type-checked using Mypy.
    You can do this by running mypy src tests.

Introduces the RetinaMNISTDataset class for handling the RetinaMNIST dataset, including data loading, transformation, and output shape methods. Adds comprehensive unit tests to verify dataset initialization, item retrieval, tensor conversion, length, and output shape.
Added RetinaMNISTDataset to the datasets module import. Updated the RetinaMNIST dataset test to use the correct dataset name, mock class, and label shape, ensuring consistency with the actual dataset implementation.
@github-actions
Copy link

github-actions bot commented Nov 2, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
901 878 97% 90% 🟢

New Files

File Coverage Status
src/matchcake_opt/datasets/retinamnist_dataset.py 100% 🟢
TOTAL 100% 🟢

Modified Files

File Coverage Status
src/matchcake_opt/datasets/init.py 100% 🟢
TOTAL 100% 🟢

updated for commit: d985c6f by action🐍

@JeremieGince JeremieGince merged commit ef1a819 into dev Nov 2, 2025
6 checks passed
@JeremieGince JeremieGince deleted the 5-add-datasets branch November 2, 2025 15:39
@JeremieGince JeremieGince mentioned this pull request Nov 2, 2025
@JeremieGince JeremieGince linked an issue Nov 2, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add datasets

1 participant