testdrive: fix --rewrite-results dropping bytes between commands#36489
Open
def- wants to merge 1 commit into
Open
testdrive: fix --rewrite-results dropping bytes between commands#36489def- wants to merge 1 commit into
def- wants to merge 1 commit into
Conversation
`parse_sql` and `parse_explain_sql` captured `expected_end` from `LineReader::raw_pos`, but `peek()` had already advanced `raw_pos` past the blank separator and the next command's query line. Rewrites of any non-last command silently dropped those bytes. Track a separate `consumed_raw_pos` that only advances when a line is actually returned to an external caller. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_sqlandparse_explain_sqlcapturedexpected_endfromLineReader::raw_pos, butpeek()had already advancedraw_pospast the blank separator and the next command's query line. Rewrites of any non-last command silently dropped those bytes. Track a separateconsumed_raw_posthat only advances when a line is actually returned to an external caller.