Skip to content

chore(console): [SAS-161] Regenerate API types and fix unrelated breakage.#37754

Merged
leedqin merged 1 commit into
mainfrom
rjimeno/sas-161-regenerate-console-api-types-and-fix-unrelated-breakage-it
Jul 21, 2026
Merged

chore(console): [SAS-161] Regenerate API types and fix unrelated breakage.#37754
leedqin merged 1 commit into
mainfrom
rjimeno/sas-161-regenerate-console-api-types-and-fix-unrelated-breakage-it

Conversation

@rjimeno-mz

Copy link
Copy Markdown
Contributor

Summary

yarn gen:api against current cloud/main picks up the name and usage fields SAS-141/SAS-145 added to the cost-breakdown response, but also pulls in ~6 other commits of unrelated API drift that accumulated in the same window. This is that regen plus the resulting fixes, landed as its own focused change so it doesn't drag unrelated region/environment-API changes into a billing-UI PR.

  • cloudGlobalApi.ts: Regions type alias repointed to the schema's renamed Paginated_Region; getSelfManagedSubscription's path param renamed useCaseIdenvironmentId, matching the backend's own rename.
  • upToDate (region "up to date" Kubernetes condition) went from optional to required. Added a "True" default at the 3 sites that construct these objects without a real value: the region mock builder, the fabricated self-managed/impersonation environment, and 2 test fixtures.
  • Restored the license header the regen silently drops from all 3 generated schema files (no banner config in redocly.yaml), so the diff doesn't spuriously delete headers from 3 files.

Unblocks SAS-142 (render account display names) and SAS-159 (render per-cluster usage), both otherwise stuck waiting on these regenerated types.

Test plan

  • yarn typecheck passes
  • yarn lint passes
  • yarn test --run — 722 passed, 1 skipped, 130 files

Linear: SAS-161

…x the region/self-managed-subscription breakage it surfaces.
@rjimeno-mz
rjimeno-mz requested a review from a team as a code owner July 20, 2026 16:30
@rjimeno-mz
rjimeno-mz requested a review from SangJunBak July 20, 2026 16:30
@linear-code

linear-code Bot commented Jul 20, 2026

Copy link
Copy Markdown

SAS-161

@rjimeno-mz rjimeno-mz self-assigned this Jul 20, 2026
@SangJunBak
SangJunBak requested review from leedqin and removed request for SangJunBak July 20, 2026 18:41

@leedqin leedqin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for doing this. Please merge this and rebase before the other billing PR :)

@leedqin
leedqin merged commit ab85c65 into main Jul 21, 2026
121 checks passed
@leedqin
leedqin deleted the rjimeno/sas-161-regenerate-console-api-types-and-fix-unrelated-breakage-it branch July 21, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants