[SS-348] implement Batches' for_each_diff_pair as an iterator (to support async operations)#37759
Open
ublubu wants to merge 1 commit into
Open
[SS-348] implement Batches' for_each_diff_pair as an iterator (to support async operations)#37759ublubu wants to merge 1 commit into
for_each_diff_pair as an iterator (to support async operations)#37759ublubu wants to merge 1 commit into
Conversation
ublubu
force-pushed
the
kynan/batch-pairs
branch
from
July 20, 2026 20:47
0ed3911 to
ead2220
Compare
ublubu
changed the title
write_data_files operator stashes Rc Batches instead of clones of rows, writes rows immediately upon reading
ublubu
marked this pull request as ready for review
July 20, 2026 20:51
ublubu
changed the title
write_data_files operator stashes Rc Batches instead of clones of rows, writes rows immediately upon readingfor_each_diff_pair as an iterator (to support async operations)
ublubu
force-pushed
the
kynan/batch-pairs
branch
from
July 21, 2026 01:15
ead2220 to
4e0d6e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to write rows to S3 as soon as we read them from the batch
instead of queuing them in memory for the next operator (
write_data_files).That means the body of our
for_each_diff_pairmust support async operations.This PR refactors
for_each_diff_pairinto an iterator so we can do that (in the stacked PR).