compute: columnar Constant output (P2)#37766
Draft
antiguru wants to merge 1 commit into
Draft
Conversation
Build the `Constant` arm of `render_plan_expr` into a `Column` and return a `CollectionEdge::Columnar`, flipping the constant literal source to emit the columnar edge. The err collection stays row-based (out of scope). The rows go through a `ConsolidatingColumnBuilder` via `to_stream_with_builder` rather than a direct columnar build. The planner (`FoldConstants`) consolidates constant rows by `(row, time)` at optimization time, but this arm then advances every time to `as_of`, which can collapse distinct original times onto one time and so reintroduce duplicates at the same `(row, time)`. Consolidating here folds those within the batch, matching the standing producer rule. The constant rows are already owned, so the give is a move into staging, not a new allocation. The `as_of` advancement and `until` filtering are unchanged. Test: extends degenerate.slt with a constant carrying duplicate rows (asserting multiplicity survives the columnar edge) and a constant feeding an indexed view and an aggregate, exercising the columnar producer against ArrangeBy and Reduce consumers. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove these sections if your commit already has a good description!
Motivation
Why does this change exist? Link to a GitHub issue, design doc, Slack
thread, or explain the problem in a sentence or two. A reviewer who has
no context should understand why after reading this section.
If this implements or addresses an existing issue, it's enough to link to that:
Closes
Fixes
etc.
Description
What does this PR actually do? Focus on the approach and any non-obvious
decisions. The diff shows the code --- use this space to explain what the
diff can't tell a reviewer.
Verification
How do you know this change is correct? Describe new or existing automated
tests, or manual steps you took.