[Fix] Add support for documents with 270 degree of page rotation#4
Open
jesusmongedev wants to merge 1 commit intoMathiasMeuleman:masterfrom
Open
[Fix] Add support for documents with 270 degree of page rotation#4jesusmongedev wants to merge 1 commit intoMathiasMeuleman:masterfrom
jesusmongedev wants to merge 1 commit intoMathiasMeuleman:masterfrom
Conversation
dchiang
reviewed
Aug 26, 2023
| const width = page.view[2]; | ||
| const height = page.view[3]; | ||
| const orientation = page.rotate === 90 ? PDFOrientation.LANDSCAPE : PDFOrientation.PORTRAIT; | ||
| const orientation = page.rotate === 270 ? PDFOrientation.LANDSCAPE : PDFOrientation.PORTRAIT; |
There was a problem hiding this comment.
I think it should be
Suggested change
| const orientation = page.rotate === 270 ? PDFOrientation.LANDSCAPE : PDFOrientation.PORTRAIT; | |
| const orientation = Math.abs(page.rotate) === 90 || Math.abs(page.rotate) === 270 ? PDFOrientation.LANDSCAPE : PDFOrientation.PORTRAIT; |
since according to metadata2go 90 and -90 are possible valid values for landscape
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3