Log inner exceptions even whe outer exception has no stack trace frames#1
Open
hotn wants to merge 1 commit intoMatrix42AG:masterfrom
Open
Log inner exceptions even whe outer exception has no stack trace frames#1hotn wants to merge 1 commit intoMatrix42AG:masterfrom
hotn wants to merge 1 commit intoMatrix42AG:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have used the improvements made by @afrischkorn for logging inner exceptions, but have found that the stack trace still gets lost if the exception type is AggregateException (common with async/await pattern) due to the AggregateException object not having a stack trace. This change will ensure that inner exceptions are processed regardless of whether or not the outer exception contains stack trace info.