Skip to content

release/v5.4.2#52

Merged
code-crusher merged 4 commits intomainfrom
release/v5.4.2
Feb 18, 2026
Merged

release/v5.4.2#52
code-crusher merged 4 commits intomainfrom
release/v5.4.2

Conversation

@code-crusher
Copy link
Member

  • fix color schema
  • fix enterprise keys multi-window sync + theme cleanups

@matter-ai-bot
Copy link
Contributor

matter-ai-bot bot commented Feb 17, 2026

Code Quality bug fix

Context

Summary By MatterAI MatterAI logo

🔄 What Changed

Release v5.4.2. This PR implements multi-window state synchronization for enterprise keys, performs a major cleanup by removing the apps/storybook directory, and refines the UI theme. Specifically, it fixes a bug in the McpView where the delete button was missing its click handler, now correctly wired to handleDelete.

🔍 Impact of the Change

Ensures consistent state across multiple VS Code windows for enterprise users. Improves repository maintainability by removing legacy assets. Restores critical functionality to the MCP server management interface by enabling the delete action.

📁 Total Files Changed

Click to Expand
File ChangeLog
MCP Fix webview-ui/src/components/mcp/McpView.tsx Wired the delete button to the handleDelete function in the confirmation dialog.
Storybook Removal apps/storybook/* Complete removal of Storybook application and associated mock data.
State Sync src/core/config/ContextProxy.ts Added refreshGlobalState to synchronize cache across windows.
Focus Sync src/core/webview/ClineProvider.ts Triggers state refresh when the VS Code window gains focus.
Theme Update src/integrations/theme/default-themes/theme-variables.css Added new CSS variables for consistent button icon backgrounds.

🧪 Test Added/Recommended

Recommended

  • Manual verification of the MCP server deletion flow in the UI.
  • Regression test for multi-window synchronization when updating enterprise keys.

🔒 Security Vulnerabilities

N/A.

Implementation

The update focuses on reliability and UI consistency. The McpView.tsx change ensures that the user's intent to delete a server is actually executed by the handleDelete handler. The broader release logic utilizes onDidChangeWindowState to trigger refreshGlobalState, ensuring that any changes made in one VS Code instance are immediately reflected in others upon focus.

Screenshots

before after
N/A N/A

How to Test

  1. Open the MCP View and attempt to delete a configured server; verify the confirmation dialog now functions.
  2. Open two VS Code windows, change a global setting in one, and verify the second window updates when focused.
  3. Verify that the UI buttons follow the updated theme variables.

Get in Touch

N/A.

⏳ Estimated code review effort

LOW (~5 minutes)

Tip

Quality Recommendations

  1. Ensure that the handleDelete function provides user feedback (e.g., a toast notification) upon successful deletion.

  2. Verify that the delete confirmation dialog closes automatically if the server is deleted via another window.

♫ Tanka Poem

Data flows through glass, 🧪
Syncing keys across the panes, 🖥️
Delete now performs, 🗑️
Clean themes shine in every light, ✨
Logic is restored. 🧬

Sequence Diagram

sequenceDiagram
    participant U as User
    participant V as McpView
    participant S as McpState
    
    U->>V: Click Delete Button
    V->>V: setShowDeleteConfirm(true)
    Note over V: Dialog Opens
    U->>V: Click Confirm Delete
    V->>V: handleDelete()
    V->>S: requestDeleteServer()
    S-->>V: success
    V->>V: setShowDeleteConfirm(false)
Loading

Copy link
Contributor

@matter-ai-bot matter-ai-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 PR Review is completed: Reviewing the removal of Storybook and updates to the core extension. Identified high-priority issues with invalid CSS values in inline styles and styled-components where Tailwind class names were used instead of CSS variables. Also noted a type safety improvement for error handling.

Skipped files
  • CHANGELOG.md: Skipped file pattern
  • apps/storybook/README.md: Skipped file pattern
  • apps/storybook/tsconfig.json: Skipped file pattern
  • pnpm-lock.yaml: Skipped file pattern

Comment on lines +434 to 435
const err = new Error(`MatterAI API Error ${error?.code}: ${error?.message}`) as any
err.status = error?.code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Code Quality

Issue: Casting the entire Error object to any disables type safety for the variable in the rest of the scope.

Fix: Cast only the specific assignment or use Object.assign to add the property safely.

Impact: Improves type safety and maintainability

Suggested change
const err = new Error(`MatterAI API Error ${error?.code}: ${error?.message}`) as any
err.status = error?.code
const err = new Error(`MatterAI API Error ${error?.code}: ${error?.message}`)
;(err as any).status = error?.code

overflow-x: auto;
overflow-y: hidden;
background-color: var(--vscode-textCodeBlock-background);
background-color: bg-vscode-editor-background;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Bug

Issue: bg-vscode-editor-background is a Tailwind class name, not a valid CSS property value. Using it directly in a CSS block (styled-component) will result in an invalid property.

Fix: Use the corresponding CSS variable var(--vscode-editor-background).

Impact: Fixes broken background styling

Suggested change
background-color: bg-vscode-editor-background;
background-color: var(--vscode-editor-background);

code {
/* Undefined wordwrap defaults to true (pre-wrap) behavior. */
background-color: var(--vscode-textCodeBlock-background) !important;
background-color: bg-vscode-editor-background !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Bug

Issue: bg-vscode-editor-background is a Tailwind class name, not a valid CSS property value. Using it directly in a CSS block will result in an invalid property.

Fix: Use the corresponding CSS variable var(--vscode-editor-background).

Impact: Fixes broken background styling

Suggested change
background-color: bg-vscode-editor-background !important;
background-color: var(--vscode-editor-background) !important;

alignItems: "center",
padding: "8px",
background: "var(--vscode-textCodeBlock-background)",
background: "bg-vscode-editor-background",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Bug

Issue: bg-vscode-editor-background is a Tailwind class name, not a valid CSS color value. Using it in the background style property will fail.

Fix: Use the corresponding CSS variable var(--vscode-editor-background).

Impact: Fixes broken background styling

Suggested change
background: "bg-vscode-editor-background",
background: "var(--vscode-editor-background)",

<div
style={{
background: "var(--vscode-textCodeBlock-background)",
background: "bg-vscode-editor-background",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Bug

Issue: bg-vscode-editor-background is a Tailwind class name, not a valid CSS color value. Using it in the background style property will fail.

Fix: Use the corresponding CSS variable var(--vscode-editor-background).

Impact: Fixes broken background styling

Suggested change
background: "bg-vscode-editor-background",
background: "var(--vscode-editor-background)",

style={{
fontSize: "13px",
background: "var(--vscode-textCodeBlock-background)",
background: "bg-vscode-editor-background",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Bug

Issue: bg-vscode-editor-background is a Tailwind class name, not a valid CSS color value. Using it in the background style property will fail.

Fix: Use the corresponding CSS variable var(--vscode-editor-background).

Impact: Fixes broken background styling

Suggested change
background: "bg-vscode-editor-background",
background: "var(--vscode-editor-background)",

@code-crusher
Copy link
Member Author

/matterai fix

@matter-ai-bot
Copy link
Contributor

matter-ai-bot bot commented Feb 17, 2026

❌ I couldn't generate code fixes for this PR. This might be because the review comments don't require code changes, or the AI couldn't determine the appropriate fixes.

@matter-ai-bot
Copy link
Contributor

matter-ai-bot bot commented Feb 18, 2026

✅ Reviewed the changes: The logic update to use handleDelete correctly wires up the confirmation action. A minor UX improvement is recommended to visually distinguish the primary action.

@code-crusher code-crusher merged commit 1ab061f into main Feb 18, 2026
6 of 13 checks passed
@code-crusher code-crusher deleted the release/v5.4.2 branch February 18, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments