Conversation
code-crusher
commented
Feb 17, 2026
- fix color schema
- fix enterprise keys multi-window sync + theme cleanups
There was a problem hiding this comment.
🧪 PR Review is completed: Reviewing the removal of Storybook and updates to the core extension. Identified high-priority issues with invalid CSS values in inline styles and styled-components where Tailwind class names were used instead of CSS variables. Also noted a type safety improvement for error handling.
Skipped files
CHANGELOG.md: Skipped file patternapps/storybook/README.md: Skipped file patternapps/storybook/tsconfig.json: Skipped file patternpnpm-lock.yaml: Skipped file pattern
| const err = new Error(`MatterAI API Error ${error?.code}: ${error?.message}`) as any | ||
| err.status = error?.code |
There was a problem hiding this comment.
🟡 Code Quality
Issue: Casting the entire Error object to any disables type safety for the variable in the rest of the scope.
Fix: Cast only the specific assignment or use Object.assign to add the property safely.
Impact: Improves type safety and maintainability
| const err = new Error(`MatterAI API Error ${error?.code}: ${error?.message}`) as any | |
| err.status = error?.code | |
| const err = new Error(`MatterAI API Error ${error?.code}: ${error?.message}`) | |
| ;(err as any).status = error?.code |
| overflow-x: auto; | ||
| overflow-y: hidden; | ||
| background-color: var(--vscode-textCodeBlock-background); | ||
| background-color: bg-vscode-editor-background; |
There was a problem hiding this comment.
🔴 Bug
Issue: bg-vscode-editor-background is a Tailwind class name, not a valid CSS property value. Using it directly in a CSS block (styled-component) will result in an invalid property.
Fix: Use the corresponding CSS variable var(--vscode-editor-background).
Impact: Fixes broken background styling
| background-color: bg-vscode-editor-background; | |
| background-color: var(--vscode-editor-background); |
| code { | ||
| /* Undefined wordwrap defaults to true (pre-wrap) behavior. */ | ||
| background-color: var(--vscode-textCodeBlock-background) !important; | ||
| background-color: bg-vscode-editor-background !important; |
There was a problem hiding this comment.
🔴 Bug
Issue: bg-vscode-editor-background is a Tailwind class name, not a valid CSS property value. Using it directly in a CSS block will result in an invalid property.
Fix: Use the corresponding CSS variable var(--vscode-editor-background).
Impact: Fixes broken background styling
| background-color: bg-vscode-editor-background !important; | |
| background-color: var(--vscode-editor-background) !important; |
| alignItems: "center", | ||
| padding: "8px", | ||
| background: "var(--vscode-textCodeBlock-background)", | ||
| background: "bg-vscode-editor-background", |
There was a problem hiding this comment.
🔴 Bug
Issue: bg-vscode-editor-background is a Tailwind class name, not a valid CSS color value. Using it in the background style property will fail.
Fix: Use the corresponding CSS variable var(--vscode-editor-background).
Impact: Fixes broken background styling
| background: "bg-vscode-editor-background", | |
| background: "var(--vscode-editor-background)", |
| <div | ||
| style={{ | ||
| background: "var(--vscode-textCodeBlock-background)", | ||
| background: "bg-vscode-editor-background", |
There was a problem hiding this comment.
🔴 Bug
Issue: bg-vscode-editor-background is a Tailwind class name, not a valid CSS color value. Using it in the background style property will fail.
Fix: Use the corresponding CSS variable var(--vscode-editor-background).
Impact: Fixes broken background styling
| background: "bg-vscode-editor-background", | |
| background: "var(--vscode-editor-background)", |
| style={{ | ||
| fontSize: "13px", | ||
| background: "var(--vscode-textCodeBlock-background)", | ||
| background: "bg-vscode-editor-background", |
There was a problem hiding this comment.
🔴 Bug
Issue: bg-vscode-editor-background is a Tailwind class name, not a valid CSS color value. Using it in the background style property will fail.
Fix: Use the corresponding CSS variable var(--vscode-editor-background).
Impact: Fixes broken background styling
| background: "bg-vscode-editor-background", | |
| background: "var(--vscode-editor-background)", |
|
/matterai fix |
|
❌ I couldn't generate code fixes for this PR. This might be because the review comments don't require code changes, or the AI couldn't determine the appropriate fixes. |
|
✅ Reviewed the changes: The logic update to use |