Release v6.6.3 - #108
Merged
Merged
Conversation
feat(orbital): continuous update-banner polling The in-app Orbital update banner no longer checks the Open VSX registry only once on mount. It now re-checks every five minutes (including while an update banner is already visible, so a newer release can replace a stale one), and whenever a long-lived view becomes visible again or the window regains focus. This keeps every open IDE window informed about subsequent releases without requiring an Extension Host restart. Polling is throttled to once per minute and pauses only while an installation or restart is actively in progress. The 'Update & Restart' action now optimistically flips the banner to an installing state before the backend confirms, so the spinner appears immediately. - Export ORBITAL_UPDATE_POLL_INTERVAL_MS from OrbitalUpdateBanner - Track update status in a ref so the poll callback sees the latest state without re-subscribing - Re-check on didBecomeVisible and window focus, throttled to 60s - Keep polling while a banner is visible; pause only while downloading/installing/restarting - Optimistically set installing status on Update & Restart click - Cover polling, visibility re-check, newer-release-while-visible, and pause-while-installing with focused tests - Bump version to 6.6.3 and add v6.6.3 release notes to CHANGELOG.md
Contributor
Contributor
|
✅ Reviewed the changes: Release v6.6.3 — version bump plus a well-structured polling mechanism for the OrbitalUpdateBanner with comprehensive test coverage. Reviewed OrbitalUpdateBanner.tsx: no issues found. The useEffect properly manages interval/listener lifecycle, uses refs to avoid stale closures, and throttles re-checks correctly. Reviewed OrbitalUpdateBanner.spec.tsx: no issues found. Tests cover polling, visibility re-checks, newer-release surfacing, and install-pause scenarios with appropriate fake timer usage and cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v6.6.3
Changed
Details
ORBITAL_UPDATE_POLL_INTERVAL_MSfromOrbitalUpdateBannerdidBecomeVisibleand windowfocus, throttled to 60s6.6.3and addv6.6.3release notes toCHANGELOG.md