Feature/misc fixes#959
Conversation
jamesrwelch
commented
Oct 21, 2025
jamesrwelch
commented
- Allow profiles to support nested sections
- Update the styling of profile sections
- Don't display dates in profiles when they're not set
- Allow linking to folders
- Insert html links where the cursor is, rather than at the end of the current HTML node
jamesrwelch
force-pushed
the
feature/misc-fixes
branch
from
60c297c to
27664e6
Compare
| </mdm-alert> | ||
| <table | ||
| *ngIf="this.profileData" | ||
| *ngIf="this.profileData.sections.length > 0" |
There was a problem hiding this comment.
Should this be
this.profileData && this.profileData.sections.length > 0
?
( I see this.profileData?.sections elsewhere that suggests this.profileData could be undefined or null )
|
|
||
| private loadDefaultCustomProfile(properties: ApiProperty[]) { | ||
| console.log(properties); | ||
| console.log(this.showCanEditPropertyAlertKey); |
| <input | ||
| type="checkbox" | ||
| style=" | ||
| width: 20px; |
There was a problem hiding this comment.
Could add to component scss?
| type="checkbox" | ||
| *ngIf="formOptionsMap[field.dataType] === 'checkbox'" | ||
| style=" | ||
| width: 20px; |
There was a problem hiding this comment.
Hmm. Perhaps it is a more general style?
| </div> | ||
| <!--Not supported for now--> | ||
| <!--<div *ngIf="formData.selectedType == 'Folder'"> | ||
| <div *ngIf="formData.selectedType == 'Folder'"> |
There was a problem hiding this comment.
Pedantic: == versus ===
formData.selectedType === 'Folder'
|
@jamesrwelch What's the status of this one? |
jamesrwelch
force-pushed
the
feature/misc-fixes
branch
from
05d16be to
db9b1fe
Compare
|
I've left the style sheeting issues because a more general tidy-up is required. I've fixed the other issues though, and re-based on Likin's PR which I've already accepted. Ready for re-review |
edwardcrichton
left a comment
edwardcrichton
left a comment
There was a problem hiding this comment.
Looks good; let's get that in
2 participants
