Conversation
This aligns with the compose spec https://docs.docker.com/reference/compose-file/services/
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses compose-spec healthcheck parsing by adding coverage for healthcheck.test provided as a single string (CMD-SHELL shorthand), and includes an update to the shared Xcode scheme launch arguments.
Changes:
- Add a static test for parsing
healthcheck.testwhen provided as a string. - Update the shared Xcode scheme
--cwdlaunch argument.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Tests/Container-Compose-StaticTests/HealthcheckConfigurationTests.swift | Adds test coverage for decoding healthcheck.test from a string form. |
| .swiftpm/xcode/xcshareddata/xcschemes/Container-Compose.xcscheme | Changes the default launch arguments (including --cwd) for the Xcode scheme. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Tests/Container-Compose-StaticTests/HealthcheckConfigurationTests.swift
Outdated
Show resolved
Hide resolved
Tests/Container-Compose-StaticTests/HealthcheckConfigurationTests.swift
Outdated
Show resolved
Hide resolved
Tests/Container-Compose-StaticTests/HealthcheckConfigurationTests.swift
Outdated
Show resolved
Hide resolved
.swiftpm/xcode/xcshareddata/xcschemes/Container-Compose.xcscheme
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…sts.swift Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…sts.swift Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…sts.swift Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/Container-Compose into fix/healthcheck-parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #58 by adding checks to allow the test parameter to be a single string instead of forcing it to be an array of strings.