✨ New feature - position: center option. #hacktoberfest#40
Open
richardevcom wants to merge 7 commits into
Open
✨ New feature - position: center option. #hacktoberfest#40richardevcom wants to merge 7 commits into
position: center option. #hacktoberfest#40richardevcom wants to merge 7 commits into
Conversation
richardevcom
changed the title
position: center option.position: center option. #hacktoberfest
Member
|
Hi, @richardevcom, thank you for contributing! There are many unnecessary changes in your Pull Request. Please undo spacing and line wrapping changes, and keep only those changes that are essential to your contribution. |
Author
|
@jprodrigues70 yeah I didn't notice the formatting only after pushing && submitting PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heyo! 👋
As part of #hacktoberfest I found your repo. I'm huge Vue.js fan so I checked out the source code and figured out it's missing
centerposition option.So - I added one.
As per your logic, I replicated
positionoption with new valuecenter. Also, since it's centered toast, I figured the animation has to fade in and grow, so I addedtransform: scale(1)instead.P.S. I hope my formatter's code reformat doesn't bother you. If so, reach out and I will save it without formatting.
Best,
Richard