Skip to content

Comments

fix: header incompatibility for gRPC#196

Open
G5277 wants to merge 3 commits intoMeesho:developfrom
G5277:feature/grpc-fix-header-compatibility
Open

fix: header incompatibility for gRPC#196
G5277 wants to merge 3 commits intoMeesho:developfrom
G5277:feature/grpc-fix-header-compatibility

Conversation

@G5277
Copy link

@G5277 G5277 commented Sep 27, 2025

🔁 Pull Request Template – BharatMLStack

📌 Summary

Updated gRPC server interceptors to use lowercase headers (online_feature_store_caller_id, online_feature_store_auth_token), ensuring HTTP/2 compliance and proper authentication with the Python client.


📂 Modules Affected

  • horizon (Real-time systems / networking)
  • online-feature-store (Feature serving infra)
  • trufflebox-ui (Admin panel / UI)
  • infra (Docker, CI/CD, GCP/AWS setup)
  • docs (Documentation updates)
  • Other: ___________

✅ Type of Change

  • Feature addition
  • Bug fix
  • Infra / build system change
  • Performance improvement
  • Refactor
  • Documentation
  • Other: ___________

📊 Benchmark / Metrics (if applicable)

N/A — change only updates header constants; no performance impact.

@Adit2607 Adit2607 changed the base branch from main to develop October 29, 2025 10:28
@turbo-turtle-github
Copy link

⚠️ CI Workflow did not complete successfully ⚠️

Reason:

IsCICDConfigFilesPresentActivity: GET https://api.github.com/repos/Meesho/BharatMLStack/contents/?ref=feature%2Fgrpc-fix-header-compatibility: 404 No commit found for the ref feature/grpc-fix-header-compatibility []

📘 Please check the Turbo Turtle FAQs for more details.

👉 If the reason is not self-explanatory or not covered in the FAQ, please reach out to @devops-oncall in the #devops-tech channel.

@Adit2607
Copy link
Contributor

Hi.. Can you please take a latest pull from develop and update the PR. I need it to sync first before going any further

@Adit2607 Adit2607 marked this pull request as draft November 18, 2025 19:01
@Adit2607 Adit2607 marked this pull request as ready for review November 18, 2025 19:01
@turbo-turtle-github
Copy link

⚠️ CI Workflow did not complete successfully ⚠️

Links:
No additional links available.

Reason:

IsCICDConfigFilesPresentActivity: GET https://api.github.com/repos/Meesho/BharatMLStack/contents/?ref=feature%2Fgrpc-fix-header-compatibility: 404 No commit found for the ref feature/grpc-fix-header-compatibility []

📘 Please check the Turbo Turtle FAQs for more details.

👉 If the reason is not self-explanatory or not covered in the FAQ, please reach out to @devops-oncall in the #devops-tech channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants