Open
Conversation
Comment on lines
70
to
76
| if idx, ok := i.rm[hlo]; ok { | ||
| entry, hashNextPrev, _ := i.rb.Get(idx) | ||
| for { | ||
| if isHashMatch(hhi, hlo, hashNextPrev) { | ||
| length, deltaExptime, lastAccess, freq, memId, offset := decode(entry) | ||
| exptime := int(deltaExptime) + int(i.startAt/60) | ||
| currentTime := int(time.Now().Unix() / 60) |
There was a problem hiding this comment.
@a0d00kc shouldn't this be inside the for loop
entry, hashNextPrev, _ := i.rb.Get(idx)
flashring/internal/cache/cache.go
Outdated
| ErrMemtableSizeNotMultipleOf4KB = fmt.Errorf("memtable size must be a multiple of 4KB") | ||
| ErrFileSizeLessThan1 = fmt.Errorf("file size must be greater than 0") | ||
| ErrFileSizeNotMultipleOf4KB = fmt.Errorf("file size must be a multiple of 4KB") | ||
| Seed = strconv.Itoa(int(time.Now().UnixNano())) |
There was a problem hiding this comment.
with seed, If the pod restarts, hashes change for the same key. Is this purposeful ?
lockless improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔁 Pull Request Template – BharatMLStack
📌 Summary
📂 Modules Affected
horizon(Real-time systems / networking)online-feature-store(Feature serving infra)trufflebox-ui(Admin panel / UI)infra(Docker, CI/CD, GCP/AWS setup)docs(Documentation updates)___________✅ Type of Change
___________📊 Benchmark / Metrics (if applicable)