Skip to content

Added isLoadTested and grafana link field to the promote request API #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shubhangi-raj-meesho wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Added isLoadTested and grafana link field to the promote request API #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b555c6
Added isLoadTested and GrafanaLink fields in the the model Payload
shubhangi-raj-meesho Feb 12, 2026
b392c43
Resolved review comments, changed the field name and removed the graf…
shubhangi-raj-meesho Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions horizon/internal/predator/handler/model.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ import (
)

type Payload struct {
ModelName string `json:"model_name"`
ModelSource string `json:"model_source_path,omitempty"`
MetaData MetaData `json:"meta_data"`
ConfigMapping ConfigMapping `json:"config_mapping"`
DiscoveryConfigID uint `json:"discovery_config_id"`
ModelName string `json:"model_name"`
ModelSource string `json:"model_source_path,omitempty"`
MetaData MetaData `json:"meta_data"`
ConfigMapping ConfigMapping `json:"config_mapping"`
DiscoveryConfigID uint `json:"discovery_config_id"`
IsLoadTested bool `json:"is_load_tested,omitempty"`
LoadTestResultsLink string `json:"load_test_results_link,omitempty"`
}

type MetaData struct {
Expand Down Expand Up @@ -44,7 +46,7 @@ type IOField struct {
}

type ConfigMapping struct {
ServiceDeployableID uint `json:"service_deployable_id"`
ServiceDeployableID uint `json:"service_deployable_id"`
SourceModelName string `json:"source_model_name,omitempty"`
}

Expand Down
7 changes: 7 additions & 0 deletions horizon/internal/predator/handler/predator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,13 @@ func (p *Predator) HandleModelRequest(req ModelRequest, requestType string) (str
if err := json.Unmarshal(payloadBytes, &payloadObject); err != nil {
return constant.EmptyString, http.StatusInternalServerError, errors.New(errMsgProcessPayload)
}
// Validate load test fields for promote requests
if requestType == PromoteRequestType && payloadObject.IsLoadTested {
if payloadObject.LoadTestResultsLink == constant.EmptyString {
return constant.EmptyString, http.StatusBadRequest, errors.New("load test results link is required when load tested is true for the model requested")
}
}

derivedModelName, err := p.GetDerivedModelName(payloadObject, requestType)
if err != nil {
return constant.EmptyString, http.StatusInternalServerError, fmt.Errorf("failed to fetch derived model name: %w", err)
Expand Down