Add functions#17
Open
vladslav wants to merge 1 commit into
Open
Conversation
getMapSpawn(map,zone) {zone is optional}
getPokemonEV(pokemonName,effort) {effort is optional}
Contributor
|
This is one small step for man, one giant leap towards being able to do literally anything with PROShine. You sure you don't want to add a function to brush your teeth for you too? ;) In all seriousness though, I'd like to suggest adding some sort of function to check if a particular map is "good" for training a particular EV in, or perhaps move to the nearest map that's "good" for a particular EV. Just a thought I had while reading through some of this. Also, the parts where it says "zone = zone or nil" and "effort = effort or nil" are unnecessary since parameters are already nil when no parameter is passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getMapSpawn(map,zone) {zone is optional}
getPokemonEV(pokemonName,effort) {effort is optional}