-
Notifications
You must be signed in to change notification settings - Fork 129
Support host.docker.internal in Linux for docker-compose #937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Since "host.docker.internal" is only available in docker desktop, it needs to be explicitly added to docker-compose.yml for Linux users. Fixes: MemMachine#918 Suggested-by: Steve Scargall <steve.scargall@memverge.com> Signed-off-by: Honggyu Kim <honggyu.kim@sk.com>
8f13139 to
b5cf7c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enables Linux users to run MemMachine with Ollama by making host.docker.internal available in the Docker Compose environment. The change adds the host.docker.internal hostname mapping to the memmachine service configuration.
Changes:
- Added
extra_hostsconfiguration to maphost.docker.internalto the host gateway in docker-compose.yml
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Some research and information on the change to help the reviewers/maintainers. What does the
|
sscargal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
|
@sscargal Thanks for the summary. That explains well about this change. |
Purpose of the change
This PR is to fix
memmachine-compose.shfor ollama in Linux environment.Description
Since "host.docker.internal" is only available in docker desktop, it needs to be explicitly added to docker-compose.yml for Linux users.
Fixes/Closes
Fixes #918
Type of change
How Has This Been Tested?
I have tested it by running
memmachine-compose.shwith ollama environment in Linux.Test Results: [Attach logs, screenshots, or relevant output]
MemMachine is ready as follows.
Checklist
Maintainer Checklist