merge queue: embarking main (0ec99e4) and #479 together#489
Closed
mergify[bot] wants to merge 2 commits into
Closed
merge queue: embarking main (0ec99e4) and #479 together#489mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
… network
Mirror the merge-box queue-row speedup for the stack context panel and the
floating stack-nav pill. Previously both surfaces only appeared after
`renderMergifyContext` finished its full network walk:
1. Find Mergify comment IDs (DOM scan or fetch the ~500KB Conversation HTML
on the Files tab).
2. Fetch each comment body (4 parallel workers).
3. Parse stack + revision markers.
The in-memory caches (`_commentBodyCache`, `_remoteCommentIdsCache`) only
help within a single SPA session — they're lost on every hard reload, so
each cold load re-paid the full network walk before either surface drew
anything.
Add a localStorage-backed `StackContextCache` (1h TTL, keyed by
org/repo/PR) that stores the parsed `stackData` and `revisionData` —
both already plain JSON-serializable objects produced by
`parseStackMarker` / `parseRevisionMarker`. `renderMergifyContext` now:
- Reads the cache synchronously and, on hit, builds + injects the panel
and nav immediately. The surfaces are on screen before the comment
fetches even start.
- Continues the existing network refresh path. `injectContextPanel`
and `injectStackNav` already dedupe via `data-mergify-hash`, so when
the fresh data matches the cached render the second injection is a
no-op. When it differs, the surfaces are swapped in place.
- Invalidates the cache when the fresh fetch reports no Mergify
comments or no panel content, so a stale entry doesn't keep showing
after the stack is dismantled upstream.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Change-Id: I02898eca47b9dfb1f7f19f8045120ba02d7eb64a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (0ec99e4) and #479 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #479.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:check-success=actionlintcheck-success=testtitle ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:#approved-reviews-by >= 2author = dependabot[bot]body ~= (?ms:.{48,})#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0Required conditions to stay in the queue:
#approved-reviews-by>=2#changes-requested-reviews-by=0#review-requested=0#review-threads-unresolved=0check-success=actionlintcheck-success=testtitle ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:#approved-reviews-by >= 2author = dependabot[bot]body ~= (?ms:.{48,})#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0