fix(sync): admin lists empty on some hosts β serve /api/collections via web session (#193)#203
Closed
jakub-przepiora wants to merge 1 commit into
Closed
fix(sync): admin lists empty on some hosts β serve /api/collections via web session (#193)#203jakub-przepiora wants to merge 1 commit into
jakub-przepiora wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: π Files selected for processing (5)
π WalkthroughWalkthroughThe live-sync snapshot endpoint now uses web session authentication while retaining its URL and controller. Snapshot failures emit console warnings, and feature tests cover authenticated, unauthenticated, and unknown-collection responses. ChangesLive-sync snapshot
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: π₯ Pre-merge checks | β 5β Passed checks (5 passed)
β¨ Finishing Touchesπ Generate docstrings
π§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (discussion #193)
On some deployments admin list pages (work orders, lines, product types, β¦) render empty even though the data exists β you can pick a line in the work-order form and save it, the planner shows sample data, but the lists stay blank.
Root cause
The lists are fed by a live-sync snapshot
GET /api/collections/{name}. It lived in the api route group and authenticated via Sanctum stateful-domain matching (Origin/Referer vs the app host). Behind a reverse proxy, or whenAPP_URLdoesn't cover the host the app is actually served on, that check fails β snapshot returns 401 β the frontend silently swallows the error into an empty list, while the rest of the SPA (session-cookie based, like the planner) keeps working.Fix
SANCTUM_STATEFUL_DOMAINStuning. URL unchanged (GET /api/collections/{name}); mobile/token clients unaffected (/api/v1/*).realtimeCollectionnow logs a console warning on snapshot failure instead of failing silently.Tests
CollectionSnapshotSessionAuthTest: authenticated session gets the snapshot (no Origin/stateful needed), guest β 401, unknown shape β 404.StatefulCollectionAccessTestkept (config still valid for other /api routes).π€ Generated with claude-flow
Summary by CodeRabbit
Bug Fixes
Tests