feat: task detail screen - #199
Merged
Merged
Conversation
Co-authored-by: MessiasLima <MessiasLima@users.noreply.github.com>
# Conflicts: # foliary/src/commonMain/composeResources/values-en/strings.xml # foliary/src/commonMain/composeResources/values/strings.xml
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done — the Task Detail feature (issue #129) is complete and verified.
What was finished
TaskDao,TaskRepository, andTaskRepositoryImplnow exposefindById(id): Flow<Task?>andsuspend delete(id).TaskShareLauncherinterface with platform implementations:ACTION_SENDchooserUIActivityViewControllerTaskDetailScreen,TaskDetailViewModel,TaskDetailNavigation, andTaskDetailNavKey.LocalUriHandlerTaskDetailNavKey.values/strings.xmlandvalues-en/strings.xml.Test fixes
TaskDetailAction.TaskMarkedCompletedside effect so the Orbit MVI test can reliably await thesaveintent.TodayScreenTestby removing theFoliaryTaskCard:Titletag assertion (clickable row merges descendants); the text assertion remains.Verification
dev.appoutlet.foliary.feature.taskdetail.*dev.appoutlet.foliary.feature.today.*dev.appoutlet.foliary.data.task.*dev.appoutlet.foliary.data.task.database.*dev.appoutlet.foliary.AppTestNo new third-party libraries were added.
Closes #129
opencode session | github run