Met Office METplus observations support via ASCII2NC#1918
Merged
JorgeBornemann merged 5 commits intomainfrom Feb 23, 2026
Merged
Met Office METplus observations support via ASCII2NC#1918JorgeBornemann merged 5 commits intomainfrom
JorgeBornemann merged 5 commits intomainfrom
Conversation
Contributor
|
|
jfrost-mo
changed the title
JorgeBornemann
requested changes
Feb 23, 2026
src/CSET/cset_workflow/app/metplus_ascii2nc/file/metoffice/ascii2nc.conf
Show resolved
Hide resolved
src/CSET/cset_workflow/app/metplus_ascii2nc/file/metoffice/ASCII2NC_UKSurface.conf
Show resolved
Hide resolved
src/CSET/cset_workflow/app/metplus_ascii2nc/file/metoffice/user_system_local.conf
Show resolved
Hide resolved
Co-authored-by: JorgeBornemann <32248422+JorgeBornemann@users.noreply.github.com>
JorgeBornemann
approved these changes
Feb 23, 2026
Collaborator
JorgeBornemann
left a comment
JorgeBornemann
left a comment
There was a problem hiding this comment.
This change is a first step in enabling ASCII2NC functionality at the Met Office, and sets the baseline for future development.
jfrost-mo
reviewed
Feb 23, 2026
| @@ -0,0 +1,15 @@ | |||
| [dir] | |||
| # any {ENV[]} variable is defined within [env] section of the rose-app.conf | |||
Member
There was a problem hiding this comment.
I'm not sure this comment is entirely accurate, as variables such as the CYLC_ ones come from elsewhere.
Comment on lines
+11
to
+12
| # TIMESTRING is linked to whattime in rose-app.conf, linked to the suite.rc so that the time formats in the suite.rc and the METplus' PointStat.conf match up. | ||
| TIMESTRING={ENV[TASK_INIT_TIME]} |
Member
There was a problem hiding this comment.
Where is TASK_INIT_TIME defined. I can't see it in the rose-app.conf.
|
|
||
| # Time relative to each input file's valid time (in seconds if no units are specified) for data within the file to be | ||
| # considered valid. | ||
| ASCII2NC_WINDOW_BEGIN = -150M |
Member
There was a problem hiding this comment.
Is is fine for this to be different than what is defined in ASCII2NC_UKSurface.conf? Two and a half hours before is a while.
Member
|
Too slow! |
7 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes enables the use of ASCII2NC with Met Office observations, fixes #1850
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.