Remove opt/ from workflow .gitignore#1924
Merged
JorgeBornemann merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
It is no longer needed, as the restricted optional configs have the restricted prefix.
jfrost-mo
added
small
Contributor
|
|
JorgeBornemann
approved these changes
Feb 24, 2026
Collaborator
JorgeBornemann
left a comment
JorgeBornemann
left a comment
There was a problem hiding this comment.
Thanks. Looks good.
One point of clarification, I am not sure that if an optional configuration has to be in the restricted files repo it can carry the restricted_ prefix, as the filename has to be rose-app-{option}.conf, so the only way to identify which repo it belongs to is to look in the repo itself. Hope this will not cause much problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is no longer needed, as the restricted optional configs have the restricted prefix.
Fixes #1921
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.