Unify saving#71
Merged
Merged
Conversation
Hemant Khatri (hmkhatri)
left a comment
Hemant Khatri (hmkhatri)
left a comment
Collaborator
There was a problem hiding this comment.
It looks good.
Have some minor comments, but can be ignored if it is not worth the effort.
Collaborator
Author
|
Thanks Hemant Khatri (@hmkhatri), changes made and tests passing! |
Hemant Khatri (hmkhatri)
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a
zarrsave option for theGlobalmodel, and made the global pipeline more robust to large ensemble sizes (~1,000,000 members) by allowingfloat32instead offloat64input.Also updated the wrapper script for running experiments with FaIR to accommodate ProFSea v3 changes.