Swap apps to use to config_loader_mod instead of configuration_mod#239
Open
mo-rickywong wants to merge 5 commits intoMetOffice:mainfrom
Open
Swap apps to use to config_loader_mod instead of configuration_mod#239mo-rickywong wants to merge 5 commits intoMetOffice:mainfrom
mo-rickywong wants to merge 5 commits intoMetOffice:mainfrom
Conversation
Contributor
Author
|
This change does alter some jedi files, a JEDI PR may be required |
ss421
approved these changes
Feb 12, 2026
ss421
left a comment
There was a problem hiding this comment.
The change here does not appear to effect applications and is used by integration and unit tests only. We should not be impacted by this.
svadams
approved these changes
Feb 18, 2026
svadams
left a comment
There was a problem hiding this comment.
Straightforward changes that look fine to me. Approving for merge
Contributor
Author
|
Have brought the PR up to head to resolve the conflicts and updated the trac.log after retesting. Should be good to go. |
jameskent-metoffice
approved these changes
Feb 25, 2026
tommbendall
approved these changes
Feb 25, 2026
mo-cjsmith
approved these changes
Feb 26, 2026
mo-cjsmith
left a comment
There was a problem hiding this comment.
All changes made keeping the code layout clean. Code owner approves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: N/A technical clean-up, straight replace on lots of files
Code Reviewer: @svadams
Code Quality Checklist
Testing
Test Suite Results - lfric_apps - SwapToConfigLoader/run1
Suite Information
Task Information
✅ succeeded tasks - 1168
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review