Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
28d07aa
rsync in FCM version of this branch
DanCopsey Feb 9, 2026
c902936
Merged in stable
DanCopsey Feb 9, 2026
726ed5a
Fix initialisation and remove zero ancil
DanCopsey Mar 26, 2026
83bbe0e
merged in main up to vn3.1
DanCopsey Mar 26, 2026
e7de852
Add my name to CONTRIBUTORS.md
DanCopsey Mar 27, 2026
96e2dd5
Addressed suggestions by Ian Boutle
DanCopsey Mar 27, 2026
021e478
Initialised inland outflow to zero
DanCopsey Mar 27, 2026
c98ab10
Corrected checksums for coupled model
DanCopsey Apr 2, 2026
c3cdc1d
Removed docstring as it was interfering with upgrade
DanCopsey Apr 2, 2026
df71126
Finished the move of inland_basin_flow from surface_fields to soil_fi…
DanCopsey Apr 2, 2026
a5a79c3
Change surface__inland_basin_flow to soil__inland_basin_flow
DanCopsey Apr 2, 2026
cdd0fb5
Apply reviewer comment
DanCopsey Apr 27, 2026
9bbe2f0
Update tag to the associated JULES PR macro, as requested by reviewer
DanCopsey Apr 28, 2026
7492fbd
Merged in head of trunk
DanCopsey May 14, 2026
820c6d7
Add new KGOs
DanCopsey May 14, 2026
0851f3c
Turn off inland basin flow coupling from the rose-stem app. This will…
DanCopsey May 19, 2026
fd97d92
Updated KGOs for coupled model as this change is expected to change r…
DanCopsey May 20, 2026
c8f7509
Add lf_inland_flow to lfric_dictionary as this will be needed once pu…
DanCopsey May 20, 2026
1b344a1
Moved upgrade macro from jules-lfric to jules-lsm after suggestion fr…
DanCopsey Jun 3, 2026
6c4f748
merged in main
DanCopsey Jun 3, 2026
b8e46ff
Moved upgrade macro to the end - after everything else
DanCopsey Jun 3, 2026
e6e3960
Corrected indent
DanCopsey Jun 3, 2026
07b3415
Remove l_inland_in
DanCopsey Jun 3, 2026
b26d85c
Rename units to unit
DanCopsey Jun 3, 2026
b16e78b
Update KGOs
DanCopsey Jun 3, 2026
1e9df5b
Move inland_basin_flow%write_field into output_diags_for_jules_soil
DanCopsey Jun 12, 2026
7cef602
Merge remote-tracking branch 'origin/main' into inland_flow
james-bruten-mo Jun 19, 2026
5264a74
apply macros
james-bruten-mo Jun 19, 2026
ed3f9da
update dependencies
james-bruten-mo Jun 22, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
| theabro | Nathan Luke Abraham | NCAS & University of Cambridge | 2026-04-15 |
| ss421 | Steven Sandbach | Met Office | 2026-04-20 |
| MichaelWhitall | Michael Whitall | Met Office | 2026-04-22 |
| DanCopsey | Dan Copsey | Met Office | 2026-05-14 |
| marcstring | Marc Stringer | NCAS, Reading University | 2026-05-06 |
| cameronbateman-mo | Cameron Bateman | Met Office | 2026-05-28 |
| davelee2804 | David Lee | Bureau of Meteorology, Australia | 2026-06-02 |
Original file line number Diff line number Diff line change
Expand Up @@ -865,3 +865,18 @@ def upgrade(self, config, meta_config=None):
)

return config, self.reports


class vn31_t401(MacroUpgrade):
"""Upgrade macro for ticket #401 by Dan Copsey."""

BEFORE_TAG = "vn3.1_t394"
AFTER_TAG = "vn3.1_t401"

def upgrade(self, config, meta_config=None):
# Commands From: rose-meta/jules-lsm
self.add_setting(
config, ["namelist:jules_hydrology", "l_inland"], ".false."
)

return config, self.reports
Original file line number Diff line number Diff line change
Expand Up @@ -830,3 +830,18 @@ def upgrade(self, config, meta_config=None):
)

return config, self.reports


class vn31_t401(MacroUpgrade):
"""Upgrade macro for ticket #401 by Dan Copsey."""

BEFORE_TAG = "vn3.1_t394"
AFTER_TAG = "vn3.1_t401"

def upgrade(self, config, meta_config=None):
# Commands From: rose-meta/jules-lsm
self.add_setting(
config, ["namelist:jules_hydrology", "l_inland"], ".false."
)

return config, self.reports
Original file line number Diff line number Diff line change
Expand Up @@ -830,3 +830,18 @@ def upgrade(self, config, meta_config=None):
)

return config, self.reports


class vn31_t401(MacroUpgrade):
"""Upgrade macro for ticket #401 by Dan Copsey."""

BEFORE_TAG = "vn3.1_t394"
AFTER_TAG = "vn3.1_t401"

def upgrade(self, config, meta_config=None):
# Commands From: rose-meta/jules-lsm
self.add_setting(
config, ["namelist:jules_hydrology", "l_inland"], ".false."
)

return config, self.reports
15 changes: 15 additions & 0 deletions applications/jedi_lfric_tests/rose-meta/jedi_common/versions.py
Original file line number Diff line number Diff line change
Expand Up @@ -865,3 +865,18 @@ def upgrade(self, config, meta_config=None):
)

return config, self.reports


class vn31_t401(MacroUpgrade):
"""Upgrade macro for ticket #401 by Dan Copsey."""

BEFORE_TAG = "vn3.1_t394"
AFTER_TAG = "vn3.1_t401"

def upgrade(self, config, meta_config=None):
# Commands From: rose-meta/jules-lsm
self.add_setting(
config, ["namelist:jules_hydrology", "l_inland"], ".false."
)

return config, self.reports
Original file line number Diff line number Diff line change
Expand Up @@ -865,3 +865,18 @@ def upgrade(self, config, meta_config=None):
)

return config, self.reports


class vn31_t401(MacroUpgrade):
"""Upgrade macro for ticket #401 by Dan Copsey."""

BEFORE_TAG = "vn3.1_t394"
AFTER_TAG = "vn3.1_t401"

def upgrade(self, config, meta_config=None):
# Commands From: rose-meta/jules-lsm
self.add_setting(
config, ["namelist:jules_hydrology", "l_inland"], ".false."
)

return config, self.reports
Original file line number Diff line number Diff line change
Expand Up @@ -865,3 +865,18 @@ def upgrade(self, config, meta_config=None):
)

return config, self.reports


class vn31_t401(MacroUpgrade):
"""Upgrade macro for ticket #401 by Dan Copsey."""

BEFORE_TAG = "vn3.1_t394"
AFTER_TAG = "vn3.1_t401"

def upgrade(self, config, meta_config=None):
# Commands From: rose-meta/jules-lsm
self.add_setting(
config, ["namelist:jules_hydrology", "l_inland"], ".false."
)

return config, self.reports
Original file line number Diff line number Diff line change
Expand Up @@ -865,3 +865,18 @@ def upgrade(self, config, meta_config=None):
)

return config, self.reports


class vn31_t401(MacroUpgrade):
"""Upgrade macro for ticket #401 by Dan Copsey."""

BEFORE_TAG = "vn3.1_t394"
AFTER_TAG = "vn3.1_t401"

def upgrade(self, config, meta_config=None):
# Commands From: rose-meta/jules-lsm
self.add_setting(
config, ["namelist:jules_hydrology", "l_inland"], ".false."
)

return config, self.reports
Original file line number Diff line number Diff line change
Expand Up @@ -865,3 +865,18 @@ def upgrade(self, config, meta_config=None):
)

return config, self.reports


class vn31_t401(MacroUpgrade):
"""Upgrade macro for ticket #401 by Dan Copsey."""

BEFORE_TAG = "vn3.1_t394"
AFTER_TAG = "vn3.1_t401"

def upgrade(self, config, meta_config=None):
# Commands From: rose-meta/jules-lsm
self.add_setting(
config, ["namelist:jules_hydrology", "l_inland"], ".false."
)

return config, self.reports
Original file line number Diff line number Diff line change
Expand Up @@ -865,3 +865,18 @@ def upgrade(self, config, meta_config=None):
)

return config, self.reports


class vn31_t401(MacroUpgrade):
"""Upgrade macro for ticket #401 by Dan Copsey."""

BEFORE_TAG = "vn3.1_t394"
AFTER_TAG = "vn3.1_t401"

def upgrade(self, config, meta_config=None):
# Commands From: rose-meta/jules-lsm
self.add_setting(
config, ["namelist:jules_hydrology", "l_inland"], ".false."
)

return config, self.reports
Original file line number Diff line number Diff line change
Expand Up @@ -865,3 +865,18 @@ def upgrade(self, config, meta_config=None):
)

return config, self.reports


class vn31_t401(MacroUpgrade):
"""Upgrade macro for ticket #401 by Dan Copsey."""

BEFORE_TAG = "vn3.1_t394"
AFTER_TAG = "vn3.1_t401"

def upgrade(self, config, meta_config=None):
# Commands From: rose-meta/jules-lsm
self.add_setting(
config, ["namelist:jules_hydrology", "l_inland"], ".false."
)

return config, self.reports
15 changes: 15 additions & 0 deletions applications/jules/rose-meta/lfric-jules/versions.py
Original file line number Diff line number Diff line change
Expand Up @@ -830,3 +830,18 @@ def upgrade(self, config, meta_config=None):
)

return config, self.reports


class vn31_t401(MacroUpgrade):
"""Upgrade macro for ticket #401 by Dan Copsey."""

BEFORE_TAG = "vn3.1_t394"
AFTER_TAG = "vn3.1_t401"

def upgrade(self, config, meta_config=None):
# Commands From: rose-meta/jules-lsm
self.add_setting(
config, ["namelist:jules_hydrology", "l_inland"], ".false."
)

return config, self.reports
Original file line number Diff line number Diff line change
Expand Up @@ -849,3 +849,18 @@ def upgrade(self, config, meta_config=None):
)

return config, self.reports


class vn31_t401(MacroUpgrade):
"""Upgrade macro for ticket #401 by Dan Copsey."""

BEFORE_TAG = "vn3.1_t394"
AFTER_TAG = "vn3.1_t401"

def upgrade(self, config, meta_config=None):
# Commands From: rose-meta/jules-lsm
self.add_setting(
config, ["namelist:jules_hydrology", "l_inland"], ".false."
)

return config, self.reports
1 change: 1 addition & 0 deletions applications/lfric_atm/example/configuration.nml
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,7 @@ write_minmax_tseries=.false.,
/
&jules_hydrology
l_hydrology=.true.,
l_inland=.false.,
l_var_rainfrac=.true.,
/
&jules_model_environment_lfric
Expand Down
1 change: 1 addition & 0 deletions applications/lfric_atm/metadata/field_def_diags.xml
Comment thread
DanCopsey marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,7 @@
<field id="soil__soil_moist_wilt" name="soil_moist_wilt" long_name="soil_moisture_at_wilting_point" unit="m3 m-3" domain_ref="face" />
<field id="soil__soil_moist_crit" name="soil_moist_crit" long_name="soil_moisture_at_critical_point" unit="m3 m-3" domain_ref="face" />
<field id="soil__soil_moist_sat" name="soil_moist_sat" long_name="soil_moisture_at_saturation" unit="m3 m-3" domain_ref="face" />
<field id="soil__inland_basin_flow" name="inland_basin_flow" long_name="Inland basin flow" unit="kg m-2 s-1" domain_ref="face" />
<!-- Boundary layer turbulence diagnostics -->
<field id="turbulence__dtheta_bl" name="dtheta_bl" long_name="potential_temperature_increment_from_bl_scheme" unit="K" grid_ref="full_level_face_grid" />
<field id="turbulence__dt_bl" name="dt_bl" long_name="temperature_increment_from_bl_scheme" unit="K" grid_ref="full_level_face_grid" />
Expand Down
5 changes: 3 additions & 2 deletions applications/lfric_atm/metadata/lfric_dictionary.xml
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@
<field id="tile_fraction" name="tile_fraction" long_name="surface_tile_fraction" unit="1" domain_ref="face" axis_ref="surface_tiles" />
<field id="tile_temperature" name="tile_temperature" long_name="surface_tile_temperature" unit="K" domain_ref="face" axis_ref="surface_tiles" />
<field id="tile_lw_grey_albedo" name="tile_lw_grey_albedo" long_name="surface_tile_lw_grey_albedo" unit="1" domain_ref="face" axis_ref="surface_tiles" />
<field id="tile_moisture_flux" name="tile_moisture_flux" long_name="tile_moisture_flux" unit="kg m-2 s-1" domain_ref="face" axis_ref="surface_tiles"/>
<field id="tile_moisture_flux" name="tile_moisture_flux" long_name="tile_moisture_flux" unit="kg m-2 s-1" domain_ref="face" axis_ref="surface_tiles"/>
<field id="snowice_melt" name="snowice_melt" long_name="snowice_melt" unit="kg m-2 s-1" domain_ref="face" axis_ref="surface_tiles"/>
<field id="surf_ht_flux" name="surf_ht_flux" long_name="surf_ht_flux" unit="W m-2" domain_ref="face" axis_ref="surface_tiles"/>
<field id="snowice_sublimation" name="snowice_sublimation" long_name="snowice_sublimation" unit="kg m-2 s-1" domain_ref="face" axis_ref="surface_tiles"/>
Expand All @@ -292,7 +292,7 @@
<field id="albedo_obs_scaling" name="albedo_obs_scaling" long_name="albedo_obs_scaling" unit="1" domain_ref="face" axis_ref="land_tile_rad_band" />
<field id="sea_ice_thickness" name="sea_ice_thickness" long_name="sea_ice_thickness" unit="m" domain_ref="face" axis_ref="sea_ice_categories" />
<field id="sea_ice_temperature" name="sea_ice_temperature" long_name="sea_ice_bulk_temperature" unit="K" domain_ref="face" axis_ref="sea_ice_categories" />
<field id="sea_ice_pensolar" name="sea_ice_pensolar" long_name="sea_ice_pensolar" unit="W m-2" domain_ref="face" axis_ref="sea_ice_categories"/>
<field id="sea_ice_pensolar" name="sea_ice_pensolar" long_name="sea_ice_pensolar" unit="W m-2" domain_ref="face" axis_ref="sea_ice_categories"/>
<field id="sea_surf_temp_pert" name="sea_surf_temp_pert" long_name="sea_surface_temperature_perturbation" unit="K" domain_ref="face" />
<field id="internal_flux" name="internal_flux" long_name="internal_flux" unit="W m-2" domain_ref="face" />
<!-- orography fields -->
Expand Down Expand Up @@ -404,6 +404,7 @@
<field id="frozen_soil_moisture" name="frozen_soil_moisture" long_name="mass_fraction_of_frozen_water_in_saturated_soil_moisture" unit="1" domain_ref="face" axis_ref="soil_levels" />
<!-- energy correction -->
<field id="temperature_correction_rate" name="temperature_correction_rate" long_name="temperature_rate_for_energy_correction" unit="K s-1" axis_ref="scalar_axis" />
<field id="lf_inland_flow" name="lf_inland_flow" long_name="lf_inland_flow" unit="kg m-2 s-1" domain_ref="face" />
<field id="lf_icefrc" name="lf_icefrc" long_name="lf_icefrc" unit="1" domain_ref="face" axis_ref="sea_ice_categories" />
<field id="lf_icetck" name="lf_icetck" long_name="lf_icetck" unit="m" domain_ref="face" axis_ref="sea_ice_categories" />
<field id="lf_icelayert" name="lf_icelayert" long_name="lf_icelayert" unit="m" domain_ref="face" axis_ref="sea_ice_categories" />
Expand Down
15 changes: 15 additions & 0 deletions applications/lfric_atm/rose-meta/lfric-lfric_atm/versions.py
Original file line number Diff line number Diff line change
Expand Up @@ -830,3 +830,18 @@ def upgrade(self, config, meta_config=None):
)

return config, self.reports


class vn31_t401(MacroUpgrade):
"""Upgrade macro for ticket #401 by Dan Copsey."""

BEFORE_TAG = "vn3.1_t394"
AFTER_TAG = "vn3.1_t401"

def upgrade(self, config, meta_config=None):
# Commands From: rose-meta/jules-lsm
self.add_setting(
config, ["namelist:jules_hydrology", "l_inland"], ".false."
)

return config, self.reports
1 change: 1 addition & 0 deletions applications/lfric_coupled/example/configuration.nml
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ write_minmax_tseries=.false.,
/
&jules_hydrology
l_hydrology=.true.,
l_inland=.false.,
l_var_rainfrac=.false.
/
&jules_model_environment_lfric
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -830,3 +830,18 @@ def upgrade(self, config, meta_config=None):
)

return config, self.reports


class vn31_t401(MacroUpgrade):
"""Upgrade macro for ticket #401 by Dan Copsey."""

BEFORE_TAG = "vn3.1_t394"
AFTER_TAG = "vn3.1_t401"

def upgrade(self, config, meta_config=None):
# Commands From: rose-meta/jules-lsm
self.add_setting(
config, ["namelist:jules_hydrology", "l_inland"], ".false."
)

return config, self.reports
Original file line number Diff line number Diff line change
Expand Up @@ -830,3 +830,18 @@ def upgrade(self, config, meta_config=None):
)

return config, self.reports


class vn31_t401(MacroUpgrade):
"""Upgrade macro for ticket #401 by Dan Copsey."""

BEFORE_TAG = "vn3.1_t394"
AFTER_TAG = "vn3.1_t401"

def upgrade(self, config, meta_config=None):
# Commands From: rose-meta/jules-lsm
self.add_setting(
config, ["namelist:jules_hydrology", "l_inland"], ".false."
)

return config, self.reports
Original file line number Diff line number Diff line change
Expand Up @@ -830,3 +830,18 @@ def upgrade(self, config, meta_config=None):
)

return config, self.reports


class vn31_t401(MacroUpgrade):
"""Upgrade macro for ticket #401 by Dan Copsey."""

BEFORE_TAG = "vn3.1_t394"
AFTER_TAG = "vn3.1_t401"

def upgrade(self, config, meta_config=None):
# Commands From: rose-meta/jules-lsm
self.add_setting(
config, ["namelist:jules_hydrology", "l_inland"], ".false."
)

return config, self.reports
15 changes: 15 additions & 0 deletions applications/ngarch/rose-meta/lfric-ngarch/versions.py
Original file line number Diff line number Diff line change
Expand Up @@ -830,3 +830,18 @@ def upgrade(self, config, meta_config=None):
)

return config, self.reports


class vn31_t401(MacroUpgrade):
"""Upgrade macro for ticket #401 by Dan Copsey."""

BEFORE_TAG = "vn3.1_t394"
AFTER_TAG = "vn3.1_t401"

def upgrade(self, config, meta_config=None):
# Commands From: rose-meta/jules-lsm
self.add_setting(
config, ["namelist:jules_hydrology", "l_inland"], ".false."
)

return config, self.reports
Original file line number Diff line number Diff line change
Expand Up @@ -830,3 +830,18 @@ def upgrade(self, config, meta_config=None):
)

return config, self.reports


class vn31_t401(MacroUpgrade):
"""Upgrade macro for ticket #401 by Dan Copsey."""

BEFORE_TAG = "vn3.1_t394"
AFTER_TAG = "vn3.1_t401"

def upgrade(self, config, meta_config=None):
# Commands From: rose-meta/jules-lsm
self.add_setting(
config, ["namelist:jules_hydrology", "l_inland"], ".false."
)

return config, self.reports
Loading
Loading