Add zenith angle dependence to sea ice albedo calculations - #438
Add zenith angle dependence to sea ice albedo calculations#438Dan Copsey (DanCopsey) wants to merge 18 commits into
Conversation
James Bruten (james-bruten-mo)
left a comment
There was a problem hiding this comment.
The upgrade macro looks fine, but you've got a new .versions file which should be deleted. It probably came during an aborted run of apply_macros.py
| =The minimum snow grain size is set here. The larger the snow grain | ||
| =size the lower the albedo in the NIR part of the spectrum. The | ||
| =recommended value is 50 um. | ||
| !kind=default |
There was a problem hiding this comment.
I would suggest setting !kind=double here and for the other 2 real-valued inputs - we are going to pass these values direct to jules at double precision (r_um), hence it makes sense to read them in at double precision (rather than the default which is usually single now)
…utle's suggestion on 16/04/2026
|
Without the new code the coupled app took 261 seconds. |
| [namelist:jules_radiation=l_sea_alb_var_chl] | ||
| trigger=namelist:files=sea_ancil_path: .true. ; | ||
|
|
||
| [namelist:jules_sea_seaice=l_zenith_albedo] |
There was a problem hiding this comment.
Can these metadata changes please be moved to:
interfaces/jules_interface/rose-meta/lfric-jules-shared/jules-sea-seaice/HEAD/rose-meta.conf
Thanks.
There was a problem hiding this comment.
Can you please run rose config-dump -C interfaces/jules_interface/rose-meta/lfric-jules-shared/jules-sea-seaice/HEAD/ thanks.
Maggie (maggiehendry)
left a comment
There was a problem hiding this comment.
I realise now that this group of tickets has not been passed into review yet as the UM branch doesn't have a PR yet. Perhaps this should be a draft still? I can't give approval until all repos are submitted.
| =order to calculate the snow albedo which also takes into account | ||
| =the zenith angle. | ||
| !kind=default | ||
| ns=namelist/Science/JULES Surface/Sea and sea-ice |
There was a problem hiding this comment.
| ns=namelist/Science/JULES Surface/Sea and sea-ice |
All the lines ns=namelist/Science/JULES Surface/Sea and sea-ice need deleting as the panels have been reorganised for JULES Science Settings
…les-shared/jules-sea-seaice/HEAD/
|
[Bulk Update] This has been removed from the Summer 2026 milestone as the review deadline has now passed. Please contact the SSD team if you think this was in error. |
PR Summary
Sci/Tech Reviewer:
Code Reviewer: Erica Neininger (@ericaneininger)
Adds a zenith angle dependence to the calculation of albedo for bare sea ice, snow on sea ice and melt ponds. See issue #400 for more details.
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - lfric_test_zenith_angle_seaice/run1
Suite Information
Task Information
✅ succeeded tasks - 1165
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review