Decide if partitioning all meshes in a multigrid mesh file#289
Draft
ukmo-juan-castillo wants to merge 2 commits intoMetOffice:mainfrom
Draft
Decide if partitioning all meshes in a multigrid mesh file#289ukmo-juan-castillo wants to merge 2 commits intoMetOffice:mainfrom
ukmo-juan-castillo wants to merge 2 commits intoMetOffice:mainfrom
Conversation
…ile need to be partitioned
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer:
Partitioning all meshes in the multigrid mesh file imposes a series of conditions regarding the number of CPUs that can be used in a job. For flexibility, it would be desirable to give the option of partitioning all multigrid meshes or not. This functionality is already present in lfric_core via the any_maps parameter of the get_partition subroutine of the panel_decomposition_type object. On the other hand, this object subroutine is not called directly in most applications, so this functionality should be made more accessible.
The solution proposed here is the creation of a logical variable in the global_mesh object, with set/get subroutines, indicating if the multiple meshes have to be partitioned. This is similar to what is presently done, where the global_mesh variable ntarget_meshes is used to find if there are multiple meshes.
Other solutions have been considered, for example:
. Extracting the any_maps parameter of the subroutine get_partition contained in the object panel_decomposition_type in successive subroutine calls until it can be used in the calling subroutine create_local_mesh. This would imply large changes in both lfric_core and lfric_apps
. Doing the same as before, but using optional subroutine parameters. Although this would minimise the number of changes in lfric_core and lfric_apps, the addition of new optional subroutine parameters is discouraged.
. Make changes in lfric applications to use the existing any_maps parameter of the subroutine get_partition. Lfric_core would not change, but this would imply duplicating large pieces of lfric_core code in the lfric_app applications that would make use of this functionality.
Any other suggestion by the reviewer would be considered and tested if necessary.
linked Lfric2lfric no multi partition lfric_apps#291
closes Select partitioning of multigrid meshes #288
fixes Select partitioning of multigrid meshes #288
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_core - lfric2lfric_no_multi_partition_core/run1
Suite Information
Task Information
✅ succeeded tasks - 384
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review