cmake configure test only when BUILD_TESTING=ON

[Matt Shin (matthewrmshin)]

Description

Determine whether to build tests by following the CTest module BUILD_TESTING option.

Impact

Follow the CTest module BUILD_TESTING option.

Checklist

• I have updated the unit tests to cover the change
• New functions are documented briefly via Doxygen comments in the code
• I have linted my code using cpplint
• I have run the unit tests
• I have run mo-bundle to check integration with the rest of JEDI and run the unit tests under all environments

[Toby Searle (twsearle)]

looks good to me. Should I wait for you to do a test of this new functionality or are we ready to merge now?

[Matt Shin (matthewrmshin)]

I've done some tests yesterday afternoon using similar branches. Sample outputs here:

• https://cylchub/services/cylc-review/taskjobs/matthew.shin/?suite=mobbm-build-testing%2Fon - -O ctest
• https://cylchub/services/cylc-review/taskjobs/matthew.shin/?suite=mobbm-build-testing%2Foff - -S BUILD_TESTING=false -z TASKS=all_make_mo

[Toby Searle (twsearle)]

I've done some tests yesterday afternoon using similar branches. Sample outputs here:

* https://cylchub/services/cylc-review/taskjobs/matthew.shin/?suite=mobbm-build-testing%2Fon - `-O ctest`

* https://cylchub/services/cylc-review/taskjobs/matthew.shin/?suite=mobbm-build-testing%2Foff - `-S BUILD_TESTING=false -z TASKS=all_make_mo`

Am I right in thinking that without setting BUILD_TESTING at all it defaults to true? I am unclear on why the CI is still running the tests on this PR.

[Matt Shin (matthewrmshin)]

Yes, BUILD_TESTING=ON is default.