Skip to content

Changes needed for ufo pr 4112 #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Toby Searle (twsearle) merged 1 commit into from
May 1, 2026
Merged

Changes needed for ufo pr 4112 #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/nemo-feedback/NemoFeedback.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,13 @@ constexpr std::string_view defaultDepthVariable{"depthBelowWaterSurface"};

NemoFeedback::NemoFeedback(
ioda::ObsSpace& obsdb, const Parameters_& params,
std::shared_ptr<ioda::ObsDataVector<int>> flags,
std::shared_ptr<ioda::ObsDataVector<float>> obsErrors)
ioda::ObsDataVector<int> & flags,
ioda::ObsDataVector<float> & obsErrors)
: obsdb_(obsdb),
data_(obsdb_),
geovars_(),
flags_(std::move(flags)),
obsErrors_(std::move(obsErrors)),
flags_(flags),
obsErrors_(obsErrors),
parameters_(params),
nameMap_(params.geoVaLsAliasFile.value()),
validityTime_(obsdb.windowStart() +
Expand Down Expand Up @@ -216,9 +216,9 @@ void NemoFeedback::write_all_data(
if (obsdb_.has("QCFlags", ufo_name)) {
variableQCFlagsData = creator.create("QCFlags", ufo_name, int32_t(0));
} else {
const size_t iv = flags_->varnames().find(ufo_name);
const size_t iv = flags_.varnames().find(ufo_name);
std::vector<int32_t> variable_qcFlags;
variable_qcFlags.assign((*flags_)[iv].begin(), (*flags_)[iv].end());
variable_qcFlags.assign(flags_[iv].begin(), flags_[iv].end());
variableQCFlagsData =
feedback_io::Data<int32_t>(creator.indexer(), variable_qcFlags);
}
Expand Down
8 changes: 4 additions & 4 deletions src/nemo-feedback/NemoFeedback.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ class NemoFeedback : public ufo::ObsFilterBase,
typedef NemoFeedbackParameters Parameters_;

NemoFeedback(ioda::ObsSpace &, const Parameters_ &,
std::shared_ptr<ioda::ObsDataVector<int> > flags,
std::shared_ptr<ioda::ObsDataVector<float> > obsErrors);
ioda::ObsDataVector<int> & flags,
ioda::ObsDataVector<float> & obsErrors);
~NemoFeedback();

void preProcess() override {}
Expand Down Expand Up @@ -80,8 +80,8 @@ class NemoFeedback : public ufo::ObsFilterBase,
ufo::ObsFilterData data_;
oops::Variables geovars_;
oops::ObsVariables extradiagvars_;
std::shared_ptr<ioda::ObsDataVector<int>> flags_;
std::shared_ptr<ioda::ObsDataVector<float>> obsErrors_;
ioda::ObsDataVector<int> & flags_;
ioda::ObsDataVector<float> & obsErrors_;
NemoFeedbackParameters parameters_;
ufo::VariableNameMap nameMap_;
const util::DateTime validityTime_;
Expand Down
Loading