Race condition tests#213
Merged
Merged
Conversation
petersilva
approved these changes
Jul 1, 2025
petersilva
left a comment
petersilva
left a comment
Contributor
There was a problem hiding this comment.
ran the tests on my 24.04 laptop, and it works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the tests to go with the changes in MetPX/sarracenia#1452
It uses a plugin to re-order messages.
When deleting a directory that contains files, normally all the files are deleted, then the directory itself gets deleted. If these messages are processed in the wrong order by the subscriber, the directory deletion should fail because it's not empty. With the new Python code, the failed deletion will get retried.
When a link is being overwritten, first a link is created with a temporary name, then it gets renamed to the correct name, overwriting the old link in the process.
The plugin re-orders messages to force: