Merged
Conversation
wrose504
force-pushed
the
svg-icon-collector
branch
from
000c9f7 to
1e422f9
Compare
Collaborator
|
Wow, nice work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The site is using SVG icons embedded via
imgtags. These have the advantage of making it simple to cache the resources and supportaltandtitleattributes, but come with the major drawback that the SVG is rendered independent of the page styles. This means that the icon colors do not match the element in which they appear:If we instead embed the SVGs directly in the HTML, then they can be styled, and can pick up the
currentColor, allowing them to match other page elements.The drawbacks of embedding the SVGs like this are that it becomes more difficult to specify the equivalent of
alttext andtitleper-instance, and to avoid reproducing the whole SVG each time we want to use it. To work around both issues, this PR adds components that can convert an existing SVG into a Blade template that can be rendered to yield the SVG with optionalaria-labelandaria-describedbyattributes, atitleelement and where the drawing primitives are captured as a reusablesymbol, so that subsequent references can justusethesymbolemitted earlier in the page.