Fix comment count to match # of comments#73
Merged
csebianlander merged 2 commits intomainfrom Aug 12, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request hopefully closes #70.
This operand ?: I guess is a shorthand for a ternary expression that "will evaluate as the first operand if it true, and the third operand otherwise" (link)
For statements like
$commentsCount > 0 ?: 0when the comment count was greater than 0, then the displayed comment count ended up being 1 for true.I made a new method for the Post model that just returns a count of non-moderation action comments, because otherwise the comment count includes whenever a moderator adds, edits, blurs etc. a comment.
This pull request should fix the comment count for the homepage, on the page for a single post, and the archive page at /archives/YYYY/MM/DD (ex. archives/2025/08/12)
(The comment count on the page for a single post will be initially accurate, but the number is not updated when a new comment is posted. Only updates on reload)