Merged
Conversation
Collaborator
|
Looks good to me!! I'm also unable to replicate the problem seen at ask.metastaging.net locally, so 🤞 this fixes things! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request will hopefully close #77 unable to log out on subsites.
I am able to log out from any subsite just fine on local. I am honestly not 100% sure why logout works on local as opposed to on staging.
I do know that using the developer tools to change the action for the logout button on staging from /logout to https://www.metastaging.net/logout results in a successful logout even from subsites. Right click the "logout" button in a subsite and edit the action as shown.
Something about the local setup allows for posting /logout to a subsite URL, but staging does not.
I am pretty sure that changing the logout action from a relative URL to a named route will solve the problem.