Merged
Conversation
csebianlander
approved these changes
Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request should close #69.
I've added the comment ID to the article element surrounding each comment (regular comments and moderator actions), so the anchor links work
There's already a data-comment-id on that element, so I could have jumped to the comments with Javascript instead, but that seemed unnecessarily complicated and I couldn't find any code that was already trying to do that.
I added comment- to the anchor link (from #{id of comment} to #comment-{id of comment}) because I was worried about the off chance that something else on the page would also happen to have the same id.