umia deployment#94
Open
Detoo wants to merge 12 commits intofeat/partial-scripifyfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
Multiple ParentCo officers — The factory now holds a list of officers instead of one. createParentCorp initializes the corp with the first officer and calls addOfficer for the rest; all officers (plus the payable address) are granted owner roles on the factory auth.
EIP-712 escrow authorization — deployCorpContractFor now verifies the escrowed signature signer is one of the registered officer, and use it tor agreement party
Production-ready deploy script — prepared for production parameters. Output safe txs JSON for importing to MetaLeX Safe (for template creation)
Misc tests