fix: Use environment variable for Node.js version in echo command#70
Merged
Conversation
cryptodev-2s
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Print Node.js version" step interpolates the node version directly into the shell command via
${{ ... }}, which is a GitHub Actions expression injection anti-pattern.This changes it to pass the value through an
envvariable instead, which is the recommended safe approach.Note
Low Risk
Logging-only change with no behavior or security surface beyond avoiding expression injection in one echo step.
Overview
The Print Node.js version step no longer embeds
${{ steps.setup-node.outputs.node-version }}in therunscript. It setsNODE_VERSIONinenvand echoes$NODE_VERSIONin bash, matching GitHub’s guidance to avoid expression injection in shell steps.Logged output is unchanged; only how the version is passed into the shell differs.
Reviewed by Cursor Bugbot for commit 741aae0. Bugbot is set up for automated code reviews on this repo. Configure here.