-
Notifications
You must be signed in to change notification settings - Fork 1
update for v1.0.0 #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,9 +6,10 @@ Reference command syntax in `references/auth.md`. | |
|
|
||
| ## Flow | ||
|
|
||
| 1. Ask the user which login method they want: MetaMask Mobile QR, Google, or Email. | ||
| 2. Execute login. | ||
| 3. Verify with token. | ||
| 1. Confirm the target environment with `mm config get env` (set with `mm config set env` before login if not `prod`). | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think agent should confirm either during login or onboarding, the agent should always default to prod. User shouldn't even need to know there are different env. Since it already has references added, power users, or users who want to debug can ask the agent to change the env. |
||
| 2. Ask the user which login method they want: MetaMask Mobile QR, Google, or Email. | ||
| 3. Execute login. | ||
| 4. Verify with token. | ||
|
|
||
| ## Login | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,18 +7,34 @@ Reference command syntax in `references/auth.md` and `references/wallet.md`. | |
| ## Flow | ||
|
|
||
| 1. Check CLI installation. | ||
| 2. Login. | ||
| 3. Initialize wallet mode. | ||
| 4. Verify auth status. | ||
| 5. Show wallet address. | ||
| 2. Configure environment (if not using production). | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above |
||
| 3. Login. | ||
| 4. Initialize wallet mode. | ||
| 5. Verify auth status. | ||
| 6. Show wallet address. | ||
|
|
||
| ## Check CLI Installation | ||
|
|
||
| ```bash | ||
| mm --version | ||
| ``` | ||
|
|
||
| If this fails, the CLI is not installed. Guide the user to install it before proceeding. | ||
| If this fails, the CLI is not installed. Guide the user to install it with `npm install -g @metamask/agentic-cli@latest` before proceeding. | ||
|
|
||
| Then run the version compatibility check from the skill `Preflight` section: compare the installed `major.minor` against the pinned `cliVersion` and the latest published release, and warn the user if they are out of sync. | ||
|
|
||
| ## Configure Environment | ||
|
|
||
| Production (`prod`) is the default. Set the target environment **before** login if the user needs dev or uat: | ||
|
|
||
| ```bash | ||
| mm config get env | ||
| mm config set env dev | ||
| ``` | ||
|
|
||
| For a one-off override without persisting, use `MM_ENV=dev mm login` (or `uat`). | ||
|
|
||
| To switch environments, run `mm config set env <prod|dev|uat>`. | ||
|
Comment on lines
+26
to
+37
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above. |
||
|
|
||
| ## Login Flow | ||
|
|
||
|
|
@@ -49,7 +65,11 @@ First check if the project is already initialized: | |
| mm init show | ||
| ``` | ||
|
|
||
| If already initialized, skip this step. Otherwise, ask the user which wallet mode they want: | ||
| If already initialized, skip this step. | ||
|
|
||
| For server-wallet mode, if the account already has a remote wallet, `mm init` syncs it and reuses the existing trading mode — no trading-mode prompt. | ||
|
|
||
| Otherwise, ask the user which wallet mode they want: | ||
| - `server-wallet` (recommended) — keys are hosted by MetaMask infrastructure. No need to manage private keys or mnemonics. | ||
| - `byok` — bring your own mnemonic. The user manages their own keys locally. | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we mention that these config will be override by
env -> MM_ENV
verbose -> --verbose
format -> --json --toon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added