Improvements#14
Merged
Merged
Conversation
hieu-w
reviewed
Jun 10, 2026
arch1995
reviewed
Jun 10, 2026
arch1995
reviewed
Jun 10, 2026
|
|
||
| `--amount` is in USDC.e. The owner EOA needs enough USDC.e and POL for gas on Polygon. | ||
|
|
||
| ### Has POL or another token on Polygon (but no USDC.e or pUSD) |
There was a problem hiding this comment.
do we still need this, can just swap and send directly to deposit wallet address ?
Member
Author
There was a problem hiding this comment.
Same chain swap doesn't accept recipient address. It was disabled later, so had to revert to this flow.
There was a problem hiding this comment.
ok, so swap to pUSD directly and then use transfer. I think it would be faster then deposit
Member
Author
There was a problem hiding this comment.
makes sense, also cheaper.
Member
Author
There was a problem hiding this comment.
@chaitanyapotti it already accounts for the POL needs to be there, if not bridge.
chaitanyapotti
previously approved these changes
Jun 10, 2026
arch1995
reviewed
Jun 10, 2026
arch1995
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description