fix: skip Solana wallet standard registration when Metamask extension exists#231
Draft
ffmcgee725 wants to merge 1 commit intomainfrom
Draft
fix: skip Solana wallet standard registration when Metamask extension exists#231ffmcgee725 wants to merge 1 commit intomainfrom
ffmcgee725 wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
When both the MetaMask extension and SDK are present, registering the SDK wallet would create a duplicate "MetaMask" entry in wallet adapters, confusing users. This change ensures only one MetaMask wallet appears in the wallet selection UI.
This PR brings back the change from #164 to prevent duplicate wallet registration when the MetaMask browser extension is already installed and registered in the Solana wallet-standard registry.
References
Checklist