chore: add optional environment_type to unified swap bridge button clicked event properties#9121
Open
ameliejyc wants to merge 2 commits into
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
For this core extension UX ticket, we want to embellish the Unified SwapBridge Button Clicked event with the
environment_typeof the UI context. These metrics do already include environment type, but they always have the valuebackgroundas that is the context used when they are emitted. We want to however have the UI context for this metric so we can tracksidepanelvspopupetc.So this PR modifies the
Unified SwapBridge Button Clickedevent properties (exported viaRequiredEventContextFromClientin@metamask/bridge-controller) to add optionalenvironment_typeto be able to pass this data in directly at the call site where the values are eithersidepanel,popuporfullscreen. Client side PR here.References
Checklist