fix: update generateDeterministicRandomNumber to reduce flakiness#9127
Open
TasadduqB wants to merge 1 commit into
Open
fix: update generateDeterministicRandomNumber to reduce flakiness#9127TasadduqB wants to merge 1 commit into
generateDeterministicRandomNumber to reduce flakiness#9127TasadduqB wants to merge 1 commit into
Conversation
… statistical test for uniformity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Details
Explanation
The
generateDeterministicRandomNumberfunction was causing flakiness in the test suite due to its random nature. To address this, we've updated the function to use a cryptographically secure pseudo-random number generator (CSPRNG) and added a statistical test for uniformity to verify that the function produces a uniform distribution.References
Fixes #5383
Checklist
Closes #5383