Skip to content

chore(smart-transactions-controller): replace configs to extend monorepo roots#9134

Merged
cryptodev-2s merged 1 commit into
mainfrom
chore/smart-transactions-controller-replace-configs
Jun 15, 2026
Merged

chore(smart-transactions-controller): replace configs to extend monorepo roots#9134
cryptodev-2s merged 1 commit into
mainfrom
chore/smart-transactions-controller-replace-configs

Conversation

@cryptodev-2s

Copy link
Copy Markdown
Contributor

Explanation

Phase B PR #9 of the package migration process guide for `@metamask/smart-transactions-controller`.

Replaced

  • `tsconfig.json` — now extends `../../tsconfig.packages.json`. Lists references for the in-monorepo upstream `@metamask/*` deps and optional peers. `noErrorTruncation` and `resolveJsonModule` preserved from the source repo's tsconfig.
  • `tsconfig.build.json` — extends `../../tsconfig.packages.build.json` and mirrors the same references with `tsconfig.build.json` paths.
  • `jest.config.js` — merges into the root `jest.config.packages.js`. Preserves the package's coverage thresholds (branches 74.65, functions 88.18, lines 92.33, statements 91.89), `setupJest.js` setup, and `testTimeout: 2500`.

Unchanged

  • `typedoc.json` — already matches the template (`scripts/create-package/package-template/typedoc.json`).
  • `setupJest.js` — kept as-is; may be removable in PR Attempt to remove required NPM modules #10 since Node 18+ has native `fetch` and `isomorphic-fetch` is no longer strictly required.

DevDependency added

  • `deepmerge@^4.2.2` (used by the new `jest.config.js`)

Package is still in `merged-packages/` so `yarn install` doesn't include it; configs aren't exercised until Phase C PR #12 moves it into `packages/`.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

…epo roots

- `tsconfig.json` now extends `../../tsconfig.packages.json` and lists
  references for in-monorepo upstream `@metamask/*` deps and optional
  peers. `noErrorTruncation` and `resolveJsonModule` are preserved
  from the source repo's tsconfig.
- `tsconfig.build.json` extends `../../tsconfig.packages.build.json`
  and mirrors the same references with `tsconfig.build.json` paths.
- `jest.config.js` merges into the root `jest.config.packages.js`,
  preserving the package's coverage thresholds (branches 74.65,
  functions 88.18, lines 92.33, statements 91.89), `setupJest.js`
  setup, and `testTimeout: 2500`.
- `typedoc.json` already matches the template — no change.
- `deepmerge@^4.2.2` added as a `devDependency` (used by the new
  `jest.config.js`).

Per Phase B PR #9 of the package-migration-process-guide.
@cryptodev-2s cryptodev-2s self-assigned this Jun 15, 2026
@cryptodev-2s cryptodev-2s requested a review from Mrtenz June 15, 2026 21:26
@cryptodev-2s cryptodev-2s enabled auto-merge June 15, 2026 21:26
@cryptodev-2s cryptodev-2s added this pull request to the merge queue Jun 15, 2026
Merged via the queue into main with commit 9dd5a2b Jun 15, 2026
379 checks passed
@cryptodev-2s cryptodev-2s deleted the chore/smart-transactions-controller-replace-configs branch June 15, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants