Skip to content

Support for OneKey device analysis#15630

Closed
originalix wants to merge 7 commits intoMetaMask:developfrom
originalix:onekey-analytics
Closed

Support for OneKey device analysis#15630
originalix wants to merge 7 commits intoMetaMask:developfrom
originalix:onekey-analytics

Conversation

@originalix
Copy link

Explanation

Please add OneKey hardware wallet support to MetaMask.

Our team reached out to Alex last week to go through the features and current metrics of OneKey, and it was a lot of fun.

Considering the MetaMask team's heavy workload, we totally understand that looking for a hardware wallet that supports QR-Code communication is your first option.

So why we still need support is simply because we use the similar communication protocol as Trezor did, which is currently supported by MetaMask. This makes the integration process minimal.

For the past year and a half, a sizable portion of OneKey's clients has bee using MetaMask (by selecting the Trezor option). A growing number of users have requested the ability to use OneKey without leaving MetaMask and selecting it from a menu of available hardware wallets.

That's basically why we submit this PR.

More Information

We want to follow forward with this PR and launch a combined marketing campaign with MetaMask to airdrop the OneKey hardware wallet to the MetaMask community as soon as possible.

We have already submitted a PR to eth-trezor-keyring to distinguish the vendor name through the getVendor method, and is currently installed using https for the time being.

After that PR is merged in, change the version number of eth-trezor-keyring here

Screenshots/Screencaps

There are no UI-related changes.

Manual Testing Steps

  • Plug in your OneKey device to your computer and unlock it.
  • Go to the "Connect Hardware Wallet" page.
  • Select Trezor hardware wallet and Create accounts.
  • analyzeForOneKey method will be called on every account created by OneKey device.

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

@originalix originalix requested review from a team and kumavis as code owners August 18, 2022 03:39
@originalix originalix requested a review from brad-decker August 18, 2022 03:39
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@AlexJupiter AlexJupiter added the team-accounts-framework Accounts team label Aug 24, 2022
@rayston92
Copy link

@kumavis @brad-decker

This PR is to help analyze the use of OneKey hardware wallets connected to MetaMask to differentiate Trezor, please review and move forward when you feel up to it, really appreciate it 🙏.

cc @Loatheb @AlexJupiter

 into onekey-analytics

# Conflicts:
#	shared/constants/hardware-wallets.js
#	yarn.lock
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Jul 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

@github-actions github-actions bot closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale issues and PRs marked as stale team-accounts-framework Accounts team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants