Support for OneKey device analysis#15630
Closed
originalix wants to merge 7 commits intoMetaMask:developfrom
Closed
Support for OneKey device analysis#15630originalix wants to merge 7 commits intoMetaMask:developfrom
originalix wants to merge 7 commits intoMetaMask:developfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
This PR is to help analyze the use of OneKey hardware wallets connected to MetaMask to differentiate Trezor, please review and move forward when you feel up to it, really appreciate it 🙏. |
Contributor
|
This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions. |
Contributor
|
This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Please add OneKey hardware wallet support to MetaMask.
Our team reached out to Alex last week to go through the features and current metrics of OneKey, and it was a lot of fun.
Considering the MetaMask team's heavy workload, we totally understand that looking for a hardware wallet that supports QR-Code communication is your first option.
So why we still need support is simply because we use the similar communication protocol as Trezor did, which is currently supported by MetaMask. This makes the integration process minimal.
For the past year and a half, a sizable portion of OneKey's clients has bee using MetaMask (by selecting the Trezor option). A growing number of users have requested the ability to use OneKey without leaving MetaMask and selecting it from a menu of available hardware wallets.
That's basically why we submit this PR.
More Information
We want to follow forward with this PR and launch a combined marketing campaign with MetaMask to airdrop the OneKey hardware wallet to the MetaMask community as soon as possible.
We have already submitted a PR to eth-trezor-keyring to distinguish the vendor name through the
getVendormethod, and is currently installed using https for the time being.After that PR is merged in, change the version number of eth-trezor-keyring here
Screenshots/Screencaps
There are no UI-related changes.
Manual Testing Steps
analyzeForOneKeymethod will be called on every account created by OneKey device.Pre-Merge Checklist
+ If there are functional changes: