chore: remove deprecated gas fee components (speedup/cancel)#40911
Open
vinistevam wants to merge 4 commits intovs/enhance-speed-up-cancel-logicfrom
Open
chore: remove deprecated gas fee components (speedup/cancel)#40911vinistevam wants to merge 4 commits intovs/enhance-speed-up-cancel-logicfrom
vinistevam wants to merge 4 commits intovs/enhance-speed-up-cancel-logicfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (2 files, +0 -177)
|
Contributor
Builds ready [bcdfa94]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Contributor
Builds ready [8fb85b4]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
vinistevam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes dead code left after the cancel/speed-up refactor (PRs #39918, #40734). The activity list now uses the new
CancelSpeedupmodal for EIP-1559 andEditGasPopoverfor legacy; the old popover and its dependencies are unused.Changes
Deleted components and hooks
{}.Updated files
useDraftTransactionWithTxParamsimport and usage;estimateToUsenow usesuserFeeLevelOverride ?? estimateUsed ?? 'medium'.EditGasFeeButtonimport and the EIP-1559 edit-gas block (button was only used here; legacy “edit” link unchanged).export {}so they remain valid modules.@import 'cancel-speedup-popover/index'.@import 'edit-gas-fee-button/index'and@import 'gas-details-item/index'.Changelog
CHANGELOG entry: null
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/7111
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk because this PR primarily deletes unused UI components, styles, tests, and i18n strings after prior refactors; main risk is accidental removal of a still-referenced translation/module causing missing labels at runtime.
Overview
Removes multiple deprecated gas fee UI surfaces (old cancel/speed-up popover, top-level advanced/edit gas fee popovers, edit-gas button/icon, and related fee/gas detail components) along with their stories, styles, and unit tests.
Cleans up references by dropping associated SCSS imports and ts-migration/test baselines, and prunes now-unused locale strings (e.g.
cancelSpeedUpLabel,dappSuggestedTooltip,maxPriorityFee,networkIsBusy) across many languages; theadvanced-gas-fee-popoverindex is converted to an empty module to reflect direct sub-component imports.Written by Cursor Bugbot for commit 8fb85b4. This will update automatically on new commits. Configure here.