ci: Publish release to GitHub after NPM

[Mrtenz]

This reorders the publish-release workflow to move the publish release to GitHub step after NPM publishing. NPM publish requires approval, and occasionally a release may be rejected and reverted, currently requiring manual removal of the Git tags and GitHub release, since those are always created before the approval.

---

Note

Medium Risk
Moderate risk because it changes the sequencing of the release pipeline (artifact build/publish dependencies), which could affect release automation if any job ordering assumptions were relied on.

Overview
The publish-release GitHub Actions workflow is restructured so the build happens first, then NPM dry-run and NPM publish run from the built artifacts, and only after NPM publish succeeds does it create the GitHub release.

This avoids creating tags/releases before the npm-publish environment approval, and adds clearer job naming while keeping the docs publish steps (gh-pages and latest) dependent on the post-publish version/output.

^{Reviewed by Cursor Bugbot for commit ff690d0. Bugbot is set up for automated code reviews on this repo. Configure here.}

[mcmire]

I see that this now goes after the doc publishing steps. Does it make sense for the doc publishing to go afterward instead?

This action also creates a Git tag in addition to creating the GitHub release. Do you think that will create a problem if the tag gets created after the package is published to NPM? I don't think so but I wanted to raise it in case it was.

[Mrtenz]

I see that this now goes after the doc publishing steps. Does it make sense for the doc publishing to go afterward instead?

They run in parallel, publish-release only needs publish-npm (just like get-release-version, which is used for publishing the docs).

This action also creates a Git tag in addition to creating the GitHub release. Do you think that will create a problem if the tag gets created after the package is published to NPM? I don't think so but I wanted to raise it in case it was.

Git and NPM tags are completely separate, so I don't think this should be a problem.

[mcmire]

Gotcha, thanks, makes sense then.

[mcmire]

LGTM.