Add support for ApprovalRevocationEnforcer#226
Merged
Conversation
7328ec5 to
0e5b25c
Compare
6 tasks
ApprovalRevocationEnforcer
ApprovalRevocationEnforcerApprovalRevocationEnforcer
744e6fb to
89622a8
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5e43b65. Configure here.
523428e to
a4d34a0
Compare
…ApprovalRevocationEnforcer
…taMask/feat/erc20-allowance-revocation-enforcer
…ive lower The test occasionally succeeds, likely because the streaming amount probably accumulates sufficiently for the transfer amount. We decrease the amountPerSecond, and increase the transferAmount
Co-authored-by: jeffsmale90 <jeffsmale90@users.noreply.github.com>
a4d34a0 to
26f37ce
Compare
mj-kiwi
previously approved these changes
May 18, 2026
54b8c0d to
26f37ce
Compare
* Add token-approval-revocation permission type and related RPC conversion * feat: add token approval revocation permission type * Revert "Add token-approval-revocation permission type and related RPC conversion" This reverts commit 086175b. * fix: link changelog entries to PR * feat: deprecate erc20-token-revocation in favor of token-approval-revocation
mj-kiwi
previously approved these changes
May 18, 2026
mj-kiwi
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

📝 Description
Adds support for
ApprovalRevocationEnforcerthroughout packages. The enforcer was added to the framework in MetaMask/delegation-framework#177🔄 What Changed?
@metamask/delegation-abis@metamask/delegation-deploymentsSmartAccountsEnvironmentin@metamask/smart-accounts-kitCaveatBuilderadded to@metamask/smart-accounts-kitEnd-to-end tests added for the new enforcer.
Deployments verified (I also tested with an incorrect contract address for the new enforcer, and it failed as expected):
List any breaking changes:
📋 Checklist
Check off completed items:
🔗 Related Issues
Link to related issues:
Closes #
Related to #
📚 Additional Notes
Any additional information, concerns, or context:
Note
Medium Risk
Medium risk: introduces a new enforcer type with new ABI/bytecode/address wiring plus new permission/caveat encoding paths, which could affect delegation/caveat construction and decoding if misconfigured.
Overview
Adds first-class support for approval revocation delegations via
ApprovalRevocationEnforceracrossdelegation-abis,delegation-core,delegation-deployments, andsmart-accounts-kit.This introduces a new ERC-7715 permission type
token-approval-revocation(and deprecateserc20-token-revocation), addsdelegation-coreterm encode/decode utilities for the enforcer’s 1-byte bitmask, and wires a newapprovalRevocationCaveatBuilder/CaveatTypeplusdecodeCaveatsupport and environment/deployment address entries.Includes new ABI/bytecode exports for
ApprovalRevocationEnforcerand adds unit + e2e coverage for term round-tripping, permission mapping, caveat building/decoding, and an ERC-20 approval revocation flow.Reviewed by Cursor Bugbot for commit 0bafc0c. Bugbot is set up for automated code reviews on this repo. Configure here.