chore: drop @arethetypeswrong/cli#600
Closed
cryptodev-2s wants to merge 1 commit into
Closed
Conversation
`attw --pack` was tail-appended to the test script. The check verifies typed-module export correctness, which is not validated by any other package in the MetaMask/core monorepo. Dropping it: - removes the @arethetypeswrong/cli devDep and its transitive highlight.js + mz deps (which Socket Security flags on the migration PR) - shrinks the test script to plain `jest` Build, lint, and 196/196 tests remain green.
Mrtenz
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
attw --packwas tail-appended to thetestscript. The check verifies typed-module export correctness — not validated by any other package inMetaMask/core, so removing it before migration keeps tooling consistent and reduces alert noise from Socket Security.Changes
@arethetypeswrong/clifromdevDependenciestestscript:"jest && attw --pack"→"jest"Why
On the migration PR (MetaMask/core#9130),
@arethetypeswrong/cli@0.18.2pulled inhighlight.js@10.7.3(obfuscated-code alert) andmz@2.7.0(network + system shell access alerts). All three transitive deps disappear with this change.Verification
yarn buildyarn lintyarn test(nowjestonly) — 196/196 pass